Update: support for target architecture for Spack Wave #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
|
Related PR opened for Libseqera: seqeralabs/libseqera#11 |
pditommaso
requested changes
Jan 31, 2024
modules/nextflow/src/main/groovy/nextflow/processor/Architecture.groovy
Outdated
Show resolved
Hide resolved
plugins/nf-wave/src/main/io/seqera/wave/plugin/SubmitContainerTokenRequest.groovy
Outdated
Show resolved
Hide resolved
plugins/nf-wave/src/main/io/seqera/wave/plugin/WaveClient.groovy
Outdated
Show resolved
Hide resolved
|
Related Wave PR opened: seqeralabs/wave#391 |
This was referenced Feb 1, 2024
This reverts commit cb04607. Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
This reverts commit 8e1a4c4. Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
marcodelapierre
force-pushed
the
update/spack_arch
branch
from
74952df to
03a58b9
Compare
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
3 tasks
|
Related Wave CLI PR : seqeralabs/wave-cli#54 |
|
Not planned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes support for target architecture
spackTargetin the case of Wave Spack builds.Supersedes #4554 to only focus on Spack Arch and ditch Spack version.