Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update build tools and fix arm64 build for rpi #111

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

reconbot
Copy link
Member

@reconbot reconbot commented Apr 19, 2023

Two problems to fix with this one

  • our rpi arm64 isn't working possibly because our libc is too new, so we'll target the lts of arm64, worked for level thankful for their investigation
  • our arm64 builds were just broken and wouldn't build so we're fixing that with a variable in our binding.gyp for openssl_fips

When this is released it will hopefully fix serialport/node-serialport#2438

@reconbot reconbot force-pushed the reconbot/update-binary-tools branch from 797fc6b to d58fba4 Compare April 20, 2023 03:05
Two problems to fix with this one
- our rpi arm64 isn't working possibly because our libc is too new, so we'll target the lts of arm64, worked for [level](Level/classic-level#71) thankful for [their investigation](Level/classic-level#69)
- our arm64 builds were just broken and wouldn't build so we're fixing that with a
@reconbot reconbot changed the title chore: update build tools chore: update build tools and fix arm64 build for rpi Apr 20, 2023
@reconbot reconbot force-pushed the reconbot/update-binary-tools branch from d58fba4 to e4b75a0 Compare April 20, 2023 03:13
@reconbot reconbot changed the title chore: update build tools and fix arm64 build for rpi fix: update build tools and fix arm64 build for rpi Apr 20, 2023
@reconbot reconbot merged commit 7a8b86f into main Apr 20, 2023
@reconbot reconbot deleted the reconbot/update-binary-tools branch April 20, 2023 03:22
@reconbot
Copy link
Member Author

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@s00d
Copy link
Contributor

s00d commented Apr 26, 2023

cool, you're back, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

[email protected] fails in docker container on rpi
2 participants