Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to reinstate support for Python 3.9 as the server I am working to do benchmarks on has it installed as system Python, and I am very much disinclined to change it. We don't need to support it as an official platform, but I would appreciate it if we could not add things requiring > py39 until we have to.
Python 3.9 is a perfectly good platform, and I see no good reason to be pushed off it for a good few years yet.
The only thing that makes our code here non Python 3.9 compatible are the type annotations, which I have to say I doubly resent now. Not only are they not particularly useful, resulting in a bunch of pointless churn and often substantially less readable code, but they are actively creating work now by forcing us away from Python 3.9.
@tomwhite - would you prefer that I add
from __future__ import annotations
to all the files here or delete the offending annotations (I'd prefer to just delete them, or make them less precise).