Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move filter expression code to filter.py #65

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Will-Tyler
Copy link
Contributor

Overview

This pull request closes #63:

FilterExpressionParser and FilterExpressionEvaluator don't really belong in a general utils.py module, but should be moved to expression.py or filter.py (or similar).

Copy link
Contributor

@tomwhite tomwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@tomwhite tomwhite merged commit 4f41fcc into sgkit-dev:main Aug 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move filter expression code to separate module
2 participants