Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get INFO/FORMAT description from attrs if present #87

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

tomwhite
Copy link
Contributor

The code in sgkit actually looks for comment keys in the attrs to populate the INFO/FORMAT description, whereas bio2zarr uses the description key.

This changes vcztools to be consistent with bio2zarr, and adds a test for generated headers.

This might be something we want to add to the spec.

Copy link
Contributor

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@jeromekelleher jeromekelleher merged commit 95a1149 into sgkit-dev:main Sep 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants