Query samples looping #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sample filtering is not implemented yet in vcztools query, but it should be easy to filter samples by applying the sample selection when loading the data in the tag generator in Some of the bcftools query examples use the |
tomwhite
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds support for looping over samples in queries. This pull request closes #83.
Testing
I add unit tests and validation tests based on the bcftools query examples. The coverage report showed good coverage, except for the case where there is no phasing information. I chose not to implement this since there isn't a test dataset with genotype data but without phasing data. If there is a convenient way to test this, I would be happy to implement it and add tests.
References