-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new store icon for aurora #550
base: master
Are you sure you want to change the base?
Conversation
|
||
when: bimanual|bool | ||
|
||
- name: Install right hand store hand icon if bimanual is true or if hand_side="right" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you updated the tests to test this icon creation (and the script)
desktop_shortcut_name: Store Right Hand | ||
comment: "This icon runs a script to put the Hand into a position where it can be stored for transportation. Hand needs to be running." | ||
folder: "{{ shadow_hand_launcher_folder }}" | ||
shell_script_file_name: store_right_hand.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments mainly for testing
Proposed changes
Add new store icon for aurora. Used for packing the hand.
Checklist
Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.
Tests
Documentation