Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new store icon for aurora #550

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BenStarmerSmith
Copy link
Contributor

Proposed changes

Add new store icon for aurora. Used for packing the hand.

Checklist

Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.

Tests

  • No tests required to be added. (For small changes that will be tested by CI/CD infrastructure).
  • Added/Modified automated and PhantomHand CI tests (if a new class is added (Python or C++), the interface of that class must be unit tested).
  • Manually tested in simulation (if simulation specific or no hardware required to test the functionality).
  • Manually tested on hardware (if hardware specific or related).

Documentation

  • No documentation required to be added.
  • Added documentation (For any new feature, explain what it does and how to use it. Write the documentation in a relevant space, e.g. Github, Confluence, etc).
  • Updated documentation (For changes to pre-existing features mentioned in the documentation).

@BenStarmerSmith BenStarmerSmith requested review from a team as code owners June 27, 2023 13:47

when: bimanual|bool

- name: Install right hand store hand icon if bimanual is true or if hand_side="right"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you updated the tests to test this icon creation (and the script)

desktop_shortcut_name: Store Right Hand
comment: "This icon runs a script to put the Hand into a position where it can be stored for transportation. Hand needs to be running."
folder: "{{ shadow_hand_launcher_folder }}"
shell_script_file_name: store_right_hand.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the this file

Copy link
Collaborator

@devops-shadow devops-shadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments mainly for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants