Berbs #2357
Merged
Berbs #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Server Is Overloaded (#65589) Co-authored-by: KylerAce <[email protected]> Co-authored-by: Kyle Spier-Swenson <[email protected]> Co-authored-by: LemonInTheDark <[email protected]>
…e_click_delay to deciseconds (#71520) theres an issue with SSinput calculating the average_click_delay that made it skip queuing clicks much faster than it should have. now it should work. also moves everything to deciseconds for consistency (except for the statpanel display, which changes it to per second). also i increased the click delay threshold to 1 tick in deciseconds because really we should only be refusing to queue if SSinput is being skipped for whatever reason or each tick is receiving massive non input overtime feex queuing clicks to lower overtime when the server is overloaded :cl: fix: queuing clicks should work correctly now /:cl:
thanks to Vallat for pointing this out whoops turns out most verbs havent been queued since may 11th because I made /datum/controller/subsystem/verb_manager have the SS_NO_INIT flag, without also removing a check in verb_manager/proc/can_queue_verb() that stops the verb callback from being queued if the subsystem isnt initialized yet. since subsystems with SS_NO_INIT obviously never have initialized set to TRUE, this always failed for every verb manager subsystem except for SSinput (because it doesnt have SS_NO_INIT). also adds a debug var to force a subsystem to always queue incoming verbs if possible. now the default verb management subsystem, and speech_controller will successfully queue verbs again. SSinput always queued verbs so that shouldnt change.
… (#70647) * fixes _queue_verb() runtiming from /client/Click() and adds info * Update code/controllers/subsystem/verb_manager.dm Co-authored-by: Mothblocks <[email protected]> Co-authored-by: Mothblocks <[email protected]>
github-actions
bot
added
DME Edit
GitHub
|
Urge to rename to biddle verbs overwhelming |
|
I will kill you |
|
biddle verbs |
|
>:C |
|
just... meet in the middle berbs |
|
birbs... |
This was referenced Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
I'm not calling them biddle verbs.
Basically, adds verbs to a queue so that they won't be run if the MC is overtiming since by default BYOND will just run them even if it means the MC won't get much/any time. tl;dr possible lag/overtime reduction from verbs like input
Ports:
tgstation/tgstation#65589
tgstation/tgstation#68990
tgstation/tgstation#70647
tgstation/tgstation#71520
Why It's Good For The Game
Overtime bad
Changelog
🆑
/:cl: