Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Floating Resort ruin to Beaches! #2371

Merged
merged 10 commits into from
Oct 16, 2023
Merged

Conversation

Zytolg
Copy link
Contributor

@Zytolg Zytolg commented Sep 22, 2023

Hello Shiptest new-Friendos! In case you don't know me, I'm Zytolg from over at /tg/. I've done a ton of mapping for various SS13 related projects, and I've finally bitten the shiptest hook. Please treat me well and thanks for having me!

About The Pull Request

Adds a new beach ruin to shiptest.

Why It's Good For The Game

More ruins = more variety. Ya'll asked me to add ruins to Beach/Rock/Scrap ruins so I'll be doing that this month :3

Forgot the image here it is
La_vida_Loca_Shiptest_Map

Changelog

🆑
add: Added the Floating Resort to Beaches. Enjoy your moment in paradise!
/:cl:

@Zytolg Zytolg requested a review from a team as a code owner September 22, 2023 17:53
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Sep 22, 2023
@Valorium-RB
Copy link

Would it be possible to place a screenshot of the ruin in your PR? Thanks!

@MarkSuckerberg
Copy link
Member

Forgive the harddel errors, they're not you're fault and I'll try to rerun it. Once #2364 gets merged it shouldn't happen anymore.

Copy link
Member

@goober3 goober3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remember to give this ruin a datum (code/datums/ruins/beachplanet.dm) & update the map catalogue! it will not spawn in-game, otherwise

also, expand the map & blend the terrain / water with some turf passthroughs, or the border between the planet and the ruin itself will look strange and unnatural!

image
remove the siding decals around the grass here, the grass creates sidings itself, which will overlap other sidings.

please add more (minor) loot & greebles to the floating resort area -- consider, a fishing area, or a dock / ladder, as well as more appliances in the villas - microwaves, lamps, refrigerators, etcetera. little tidbits of loot to satisfy scrappers.

code/game/area/areas/ruins/beachplanet.dm Outdated Show resolved Hide resolved
@Zytolg Zytolg requested a review from goober3 October 1, 2023 19:22
Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me!
thanks for making ruins <3

@goober3 goober3 dismissed their stale review October 16, 2023 16:39

addressed

@spockye spockye added this pull request to the merge queue Oct 16, 2023
Merged via the queue into shiptest-ss13:master with commit 838b792 Oct 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants