Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Inkwell-class Supply Freighter #2385

Merged
merged 42 commits into from
Nov 9, 2023

Conversation

Imaginos16
Copy link
Member

@Imaginos16 Imaginos16 commented Sep 30, 2023

Wait, isn't there a freeze right now?

Correct, there is a ship freeze currently, but I have received permission from @Apogee-dev to create the PR for this vessel, as it was a ship I've been working on since at least early-to-mid August.
image

If any other maptainer would like to overrule Apogee, I'd be more than happy to temporarily close the PR. Until then, here it is!

About The Pull Request

Hello everyone! Mr. SolGov here again to add yet another ship to be tested!

This PR adds a completely new vessel, that being the Inkwell-class Supply Freighter, a ship known for its vast cargo space!

2023-10-13 13 54 57

2023-10-13 13 54 59

With extra starter money, three sonnensöldners, and three miners, players can enjoy completing bounties like no tomorrow, have drinks with their crewmates in peace, and supply other SolGov vessels with much needed equipment in less time than you can say "I ran out of ammo!"

Notable things in this ship include:

  • Turrets (with IFF!)
  • A bar!
  • A full-blown cafeteria with a small kitchen and lounge!
  • An office space for bureaucrats and scribes!
  • Decently-sized quarters for the Logistics Deck Officer and Captain!
  • A massive cargo bay with pre-existing supplies!
  • A secret compartment for private storage!

And finally, as for jobs, there are:

  • 1 Captain
  • 1 Logistics Deck Officer
  • 3 Sonnensöldneren
  • 2 Space Engineers
  • 3 Field Engineers
  • 2 Bureaucrats
  • 6 Scribes

Why It's Good For The Game

More SolGov content is nice! Especially when it comes to ships, for a faction that only has two existing at the moment, haha.

Changelog

🆑 PositiveEntropy
add: The Solarian Port Authority Has Now Permitted Inkwell-class Vessels To Explore The Stars!
/:cl:

@Imaginos16 Imaginos16 requested a review from a team as a code owner September 30, 2023 18:34
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Sep 30, 2023
Copy link
Member

@goober3 goober3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
exterior signs / decals must be placed directly on the hull -- anything placed on a turf passthrough is dropped when a ship loads. also, please avoid wallmounts stacking like this. (even if they're on opposite sides of a wall!)

image
this is Bad!! please shift all of your posters 32 pixels into walls, for consistency's sake.

image
these spawners create abandoned crates, not crate loot! maintenance spawners can be used, if you want your crates to be filled with random junk.

image
make this area a storage bay, perhaps. this room does not look external to me!

image
move these satchels into the mining prep room, and make sure there's enough for each field engineer. you could probably put an ore box down here.

image
give them some Fruit and Veggies. moths cannot eat this!!

awesome ship!! I look forward to seeing it in-game.

Copy link
Member

@goober3 goober3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
doubled up areas. change the second starboard maint area to a storage room.

i'll be away from my computer for a few days after this review. so consider this an approval in advance. good job.

@Zevotech
Copy link
Contributor

not sure if it was due to some fuckery but the bottom left ion thruster seemed to have a light fixture hanging off of it. might have gotten put there by mistake.

Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

unconnected pipe ( ARMOURY )

image

i'd say replace these with the vaccum suit type. these ones are a bit stronk for a cargo ship.

@Latentish Latentish requested review from spockye and goober3 October 30, 2023 08:02
@goober3 goober3 added this pull request to the merge queue Nov 9, 2023
@goober3 goober3 removed this pull request from the merge queue due to a manual request Nov 9, 2023
@goober3 goober3 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into shiptest-ss13:master with commit 590e8cb Nov 9, 2023
10 checks passed
MysticalFaceLesS added a commit to CeladonSS13/Shiptest that referenced this pull request Nov 10, 2023
@Imaginos16 Imaginos16 deleted the inkwell branch November 12, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants