Fixes Nomadcrash and the areas of Budgetcuts and Miningexpedition #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Map Change
|
Tm........... |
|
Please link the original pr in your description if you wouldn't mind. |
(bites you) Okay............ |
|
Could you also please provide screenshots of the area'ing of these ruins in sdmm? |
(bites you again) Hi hiii haiiii :3 |
Erikafox
suggested changes
Nov 8, 2023
Zevotech
changed the title
|
Updated, turfs repathed so its mergable. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: zevo <[email protected]>
Zevotech
changed the title
|
Should be fixed. Please TM. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
shiptest-server
pushed a commit
that referenced
this pull request
Feb 28, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Feb 28, 2024
…iptest-ss13#2448) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## turfs repathed this is mergable now thank you for waiting ## About The Pull Request shiptest-ss13#2384 Fixes the areas on nomadcrash and the two other rockplanet ruins that were given areas but never had them applied. Fixes the enemy selection on nomadcrash to better fit rockplanets mob pool. Repaths the turfs used in nomadcrash to be properly subtyped from their actual turfs and use rockplanet atmos.     ## Why It's Good For The Game Who merged this without checking it on a testmerge thoroughly? I just want to talk. Anyways ruins should probably use the correct areas and not have really fucky tiles. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: fix: rockplanet_nomadcrash now uses the correct areas. fix: rockplanet_nomadcrash now uses correctly pathed turfs that dont break when spawned. fix: rockplanet_budgetcuts and rockplanet_miningexpedition now use their newly added respective areas instead of ruin/powered. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: zevo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turfs repathed this is mergable now thank you for waiting
About The Pull Request
#2384
Fixes the areas on nomadcrash and the two other rockplanet ruins that were given areas but never had them applied.
Fixes the enemy selection on nomadcrash to better fit rockplanets mob pool.
Repaths the turfs used in nomadcrash to be properly subtyped from their actual turfs and use rockplanet atmos.
Why It's Good For The Game
Who merged this without checking it on a testmerge thoroughly? I just want to talk.
Anyways ruins should probably use the correct areas and not have really fucky tiles.
Changelog
🆑
fix: rockplanet_nomadcrash now uses the correct areas.
fix: rockplanet_nomadcrash now uses correctly pathed turfs that dont break when spawned.
fix: rockplanet_budgetcuts and rockplanet_miningexpedition now use their newly added respective areas instead of ruin/powered.
/:cl: