Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds screenless IPCs #2513

Merged
merged 18 commits into from
Feb 10, 2024
Merged

Adds screenless IPCs #2513

merged 18 commits into from
Feb 10, 2024

Conversation

rye-rice
Copy link
Member

@rye-rice rye-rice commented Nov 21, 2023

About The Pull Request

This adds support for screenless IPCs. Most notably adds the Sprinter IPC chasis (by @Ebin-Halcyon ) to show this off

image

image

Also adds IPC tails

Why It's Good For The Game

More IPC customization

Also Synths are no longer FBP jank, but who cares? Screenless IPC support!

Changelog

🆑 Halcyon, retlaw34, thgvr
add: Added the Sprinter IPC Chassis
add: Added the PGF MECHANICS IPC Chassis
add: Adds IPC tails
tweak: Robotic eyes now use the synth eye sprite.
/:cl:

@rye-rice rye-rice requested a review from a team as a code owner November 21, 2023 16:19
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Nov 21, 2023
@rye-rice rye-rice marked this pull request as draft November 21, 2023 23:55
@rye-rice
Copy link
Member Author

drafting because i realized i could add more stuff, please still test merge this

@thgvr
Copy link
Member

thgvr commented Nov 22, 2023

Dw it will be done

@Sweettoothart
Copy link

Issue: Synth tails are consistent between IPC character slots.

Replication: Choose tail for an ipc, go to another ipc slot, the tail will be the same option as the one previously chosen.

icon_state = "cat"

/datum/sprite_accessory/ipc_tail/fox
name = "Pawsitrons Fox"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't like these, doesn't feel very ipc to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not? besides,synths aren't very classic ipc-ey,either

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love them and I've seen a couple IPCs with them. They're very cool

@rye-rice rye-rice marked this pull request as ready for review November 26, 2023 01:41
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Nov 26, 2023
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Nov 27, 2023
@rye-rice
Copy link
Member Author

marge please

@MarkSuckerberg
Copy link
Member

gotta fix whatever this is first
Limb generated with nonexistant icon. File: icons/mob/species/ipc/bodyparts.dmi | State: pgfipc-d_r_leg

@rye-rice
Copy link
Member Author

rye-rice commented Jan 7, 2024

Yeahhh, the digi right leg shows up in game, so I have no clue what it could be

Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't merge this until the error's resolved one way or another
the issue is that it's trying to generate the limbs with non-digitigrade icons, so either find a way to fix that or just add plantigrade sprites for the pgf ipc limbs (pgfipc-d_r_leg and pgfipc-d_l_leg)

@rye-rice
Copy link
Member Author

Ohhhhhhhhhh
Oh okay I think I get it now

@rye-rice
Copy link
Member Author

can't merge this until the error's resolved one way or another the issue is that it's trying to generate the limbs with non-digitigrade icons, so either find a way to fix that or just add plantigrade sprites for the pgf ipc limbs (pgfipc-d_r_leg and pgfipc-d_l_leg)

OOOOH I DID IT, ITS FIXED!!!

I tested in game, digi variant still works

@thgvr thgvr dismissed MarkSuckerberg’s stale review February 9, 2024 22:46

the error is resolved

@thgvr thgvr added this pull request to the merge queue Feb 9, 2024
Merged via the queue into shiptest-ss13:master with commit 9f7c357 Feb 10, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Feb 11, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

This adds support for screenless IPCs. Most notably adds the Sprinter
IPC chasis (by @Ebin-Halcyon ) to show this off

![image](https://github.com/shiptest-ss13/Shiptest/assets/58402542/9674864e-06c5-410c-85ed-867425691791)

![image](https://github.com/shiptest-ss13/Shiptest/assets/58402542/f5bbea33-c064-4857-8e70-cc324d2d2dc9)

Also adds IPC tails

More IPC customization

Also Synths are no longer FBP jank, but who cares? Screenless IPC
support!

:cl: Halcyon, retlaw34, thgvr
add: Added the Sprinter IPC Chassis
add: Added the PGF MECHANICS IPC Chassis
add: Adds IPC tails
tweak: Robotic eyes now use the synth eye sprite.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants