(probably) actually fixes outpost baseturfs, removes holodecks #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
tmtmtl30
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
shiptest-server
pushed a commit
that referenced
this pull request
Jan 14, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Jan 14, 2024
…est-ss13#2598) ## About The Pull Request changes the behavior downstream of /datum/map_template's should_place_on_top (the particular proc in question is build_coordinate, and its placeOnTop variable) so that, when false, the baseturfs of the resulting turf are set to the baseturfs of the type being placed, instead of the previous behavior, which preserved the old baseturfs entirely. this odd behavior seemed to be specialized for holodecks, and i mistakenly assumed it'd work for outposts given the variable name and an experiment on a testing map. the behavior has been changed to alter the baseturfs according to the type (so that placing a template with should_place_on_top = FALSE results in the same baseturfs list as you'd get from a changeturf(type, initial(type.baseturfs) call), so that outposts should now place with the correct baseturfs. this enables planetary outposts with a special baseturf defined in a ztrait; before, they would be stuck with a space turf hiding in the baseturf list, making their baseturfs basically always broken. in order to accommodate this change without breaking holodeck code, holodeck code has been largely removed, with a few exceptions where it'd be a slight pain to remove certain turfs / objects that were originally used in holodecks but which had been since used in other maps. there's also a bit of admin functionality upstream of some holodeck procs that i didn't want to touch ## Why It's Good For The Game outposts spacing themselves when people pry up tiles is bad, and a fix like this is necessary for planetary outposts to ever have the right baseturfs. ## Changelog :cl: del: Holodeck code has been removed. fix: Outposts should end up erroneously spaced less frequently. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
changes the behavior downstream of /datum/map_template's should_place_on_top (the particular proc in question is build_coordinate, and its placeOnTop variable) so that, when false, the baseturfs of the resulting turf are set to the baseturfs of the type being placed, instead of the previous behavior, which preserved the old baseturfs entirely.
this odd behavior seemed to be specialized for holodecks, and i mistakenly assumed it'd work for outposts given the variable name and an experiment on a testing map. the behavior has been changed to alter the baseturfs according to the type (so that placing a template with should_place_on_top = FALSE results in the same baseturfs list as you'd get from a changeturf(type, initial(type.baseturfs) call), so that outposts should now place with the correct baseturfs. this enables planetary outposts with a special baseturf defined in a ztrait; before, they would be stuck with a space turf hiding in the baseturf list, making their baseturfs basically always broken.
in order to accommodate this change without breaking holodeck code, holodeck code has been largely removed, with a few exceptions where it'd be a slight pain to remove certain turfs / objects that were originally used in holodecks but which had been since used in other maps. there's also a bit of admin functionality upstream of some holodeck procs that i didn't want to touch
Why It's Good For The Game
outposts spacing themselves when people pry up tiles is bad, and a fix like this is necessary for planetary outposts to ever have the right baseturfs.
Changelog
🆑
del: Holodeck code has been removed.
fix: Outposts should end up erroneously spaced less frequently.
/:cl: