Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizes the Komodo #2701

Merged
merged 13 commits into from
Apr 11, 2024
Merged

Conversation

goober3
Copy link
Member

@goober3 goober3 commented Feb 5, 2024

To-do

  • Rotate the Komodo
  • Armory Nerf
  • Medical Nerf

About The Pull Request

This PR:

  • Fixes various issues with stacked and floating wallmounts on the Komodo.
  • Adds a refueling system for the plasma and air tanks.
  • Nerfs the power generators.
  • Removes the ORM.
  • Moves light switches to more convenient locations.
  • Removes the NanoMed and re-organises medical slightly.
  • Removes the Bulldog, SRM pistol, Syndicate Derringer, and Infiltrator Rifle.
  • Adds a Stechkin and 357. Revolver for the Sergeant and Captain, respectively.
  • Removes the Security RnD kit.
  • Trims the Bartender's locker slightly, including the shotgun, which they had for some reason.
  • Adds a Peacekeeping locker to the armory.
  • Removes the engineering vendor.
  • Gets a little silly with it.

Screenshots

666675ed82834ce45b843cf92cdcbe93
image
image

Changelog

🆑
tweak: The Komodo has been tweaked, including some nerfs and wallmount fixes.
/🆑

@goober3 goober3 requested a review from a team as a code owner February 5, 2024 23:42
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Merge Conflict Use Git Hooks, you're welcome. Map Change Tile placing is hard. Thank you for your service. labels Feb 5, 2024
@goober3
Copy link
Member Author

goober3 commented Feb 5, 2024

oh, look. merge conflicts. i'll fix this tomorrow.

@github-actions github-actions bot added Merge Conflict Use Git Hooks, you're welcome. and removed Merge Conflict Use Git Hooks, you're welcome. labels Feb 7, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Merge Conflict Use Git Hooks, you're welcome. and removed Merge Conflict Use Git Hooks, you're welcome. labels Feb 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@thgvr
Copy link
Member

thgvr commented Feb 26, 2024

wawa

@meemofcourse meemofcourse linked an issue Feb 26, 2024 that may be closed by this pull request
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Mar 29, 2024
Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on live, don't see any immediate issues with it. The Komodo is still in this awkward place of being our only Hardsliner ship without proper hardliner representation. Which is to say we need a new hardliner ship. So whenever that happens this will need another pass over. But for not this is good.

@Latentish
Copy link
Member

Waiting for some more changes before a merge as requested.

@Latentish Latentish added this pull request to the merge queue Apr 10, 2024
@Latentish
Copy link
Member

Mergathons.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2024
@Latentish Latentish added this pull request to the merge queue Apr 11, 2024
Merged via the queue into shiptest-ss13:master with commit 5c9c48e Apr 11, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Apr 12, 2024
## To-do

- [x] Rotate the Komodo
- [x] Armory Nerf
- [x] Medical Nerf 

## About The Pull Request
This PR:

- Fixes various issues with stacked and floating wallmounts on the
Komodo.
- Adds a refueling system for the plasma and air tanks.
- Nerfs the power generators.
- Removes the ORM.
- Moves light switches to more convenient locations.
- Removes the NanoMed and re-organises medical slightly.
- Removes the Bulldog, SRM pistol, Syndicate Derringer, and Infiltrator
Rifle.
- Adds a Stechkin and 357. Revolver for the Sergeant and Captain,
respectively.
- Removes the Security RnD kit.
- Trims the Bartender's locker slightly, including the shotgun, which
they had for some reason.
- Adds a Peacekeeping locker to the armory.
- Removes the engineering vendor.
- Gets a little silly with it.

## Screenshots

![666675ed82834ce45b843cf92cdcbe93](https://github.com/shiptest-ss13/Shiptest/assets/118859017/7cb8ab2f-3ea1-48b9-ace1-bab64bd05ac8)

![image](https://github.com/shiptest-ss13/Shiptest/assets/118859017/bc5bb9f0-3e8c-4fc7-b5ef-f4746ec70d08)

![image](https://github.com/shiptest-ss13/Shiptest/assets/118859017/d32a0ea6-8eae-41e3-b7ad-aaf7e0d54603)

## Changelog

🆑
tweak: The Komodo has been tweaked, including some nerfs and wallmount
fixes.
/🆑
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Apr 15, 2024
## To-do

- [x] Rotate the Komodo
- [x] Armory Nerf
- [x] Medical Nerf 

## About The Pull Request
This PR:

- Fixes various issues with stacked and floating wallmounts on the
Komodo.
- Adds a refueling system for the plasma and air tanks.
- Nerfs the power generators.
- Removes the ORM.
- Moves light switches to more convenient locations.
- Removes the NanoMed and re-organises medical slightly.
- Removes the Bulldog, SRM pistol, Syndicate Derringer, and Infiltrator
Rifle.
- Adds a Stechkin and 357. Revolver for the Sergeant and Captain,
respectively.
- Removes the Security RnD kit.
- Trims the Bartender's locker slightly, including the shotgun, which
they had for some reason.
- Adds a Peacekeeping locker to the armory.
- Removes the engineering vendor.
- Gets a little silly with it.

## Screenshots

![666675ed82834ce45b843cf92cdcbe93](https://github.com/shiptest-ss13/Shiptest/assets/118859017/7cb8ab2f-3ea1-48b9-ace1-bab64bd05ac8)

![image](https://github.com/shiptest-ss13/Shiptest/assets/118859017/bc5bb9f0-3e8c-4fc7-b5ef-f4746ec70d08)

![image](https://github.com/shiptest-ss13/Shiptest/assets/118859017/d32a0ea6-8eae-41e3-b7ad-aaf7e0d54603)

## Changelog

🆑
tweak: The Komodo has been tweaked, including some nerfs and wallmount
fixes.
/🆑
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The Entirety of the Komodo's Bar
3 participants