Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissection tweaks: I'm tired of the corpse pile #2722

Merged
merged 9 commits into from
Mar 4, 2024

Conversation

SomeguyManperson
Copy link
Contributor

@SomeguyManperson SomeguyManperson commented Feb 11, 2024

About The Pull Request

Problem: people are dissecting well-documented life like common animals and, distressingly, human corpses. Not only is this behavior odd, cadaver disposal methods can end up being quite concerning. Or quite concerningly non-instanced.

Solution: Dissections no longer provide points as a default for animal/humanoid corpses, massively shortening the list of dissectable things. Pod and jellypeople have also been removed from the modified dissections table as people since they are both playable (pods less but still) and slimes can show up as legion corpses.
In their place, crystal mobs, ancient goliaths, and elites/megafauna can be dissected, since they are both unique and rare (relatively)

I also switched the dissection variant scaling to be fractional of the expected maximum at advanced surgery/experimental tier dissection, since that's what is going to be used throughout the majority of a round and having the commonly used numbers more directly present makes for easier balance checks.

New dissectable things at experimental dissection research outputs, halve and quarter for thorough and base outputs respectively:
Megafauna: 60k, on par with xeno bodies. Since you can't drag these, a clinic would have to be prepared on-site for the ones that leave a body (dragon) to extract the full value, and they are both rare and more than capable of killing a crew
Elites: 12k, uncommon spawn on some planets, can be lethal
crystal goliath: 10k, likely less lethal than the crystal legion but still dangerous
mega arachnid, 8k, Appears in one ruin as a miniboss, rare enough it'd be something to peek at
forgotten watcher: 6k, rare but relatively harmless compared to the other crystal mobs (unless I'm missing something)
watcher variants: 4k, uncommon subspecies of watchers
ancient goliath: 4k, it's a remarkably old goliath, probably some value there

Why It's Good For The Game

Five. Hundred. Human bodies. In my medbay.

Changelog

🆑
add: ancient goliaths, crystal fauna (aside from legion), elites and megafauna now have boosted dissection outputs
del: human corpses, podpeople, jellypeople and animal corpses can no longer be dissected. What did you expect to find, an extra pair of lungs?
/:cl:

@keywordlabeler keywordlabeler bot added the Tweak label Feb 11, 2024
@github-actions github-actions bot added the Code change Watch something violently break. label Feb 11, 2024
@Sun-Soaked
Copy link
Member

we are so back

@thgvr
Copy link
Member

thgvr commented Feb 15, 2024

Remind me to review this this weekend.

Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely wonderful PR

code/modules/surgery/experimental_dissection.dm Outdated Show resolved Hide resolved
Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the honourable ship's doctor breathes a deep sigh of relief as a weight is lifted from their shoulders for good

@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Mar 4, 2024
Merged via the queue into shiptest-ss13:master with commit 783d519 Mar 4, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Mar 5, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Problem: people are dissecting well-documented life like common animals
and, distressingly, _human corpses._ Not only is this behavior odd,
cadaver disposal methods can end up being quite concerning. Or quite
concerningly non-instanced.

Solution: Dissections no longer provide points as a default for
animal/humanoid corpses, massively shortening the list of dissectable
things. Pod and jellypeople have also been removed from the modified
dissections table as people since they are both playable (pods less but
still) and slimes can show up as legion corpses.
In their place, crystal mobs, ancient goliaths, and elites/megafauna can
be dissected, since they are both unique and rare (relatively)

I also switched the dissection variant scaling to be fractional of the
expected maximum at advanced surgery/experimental tier dissection, since
that's what is going to be used throughout the majority of a round and
having the commonly used numbers more directly present makes for easier
balance checks.

New dissectable things at experimental dissection research outputs,
halve and quarter for thorough and base outputs respectively:
Megafauna: 60k, on par with xeno bodies. Since you can't drag these, a
clinic would have to be prepared on-site for the ones that leave a body
(dragon) to extract the full value, and they are both rare and more than
capable of killing a crew
Elites: 12k, uncommon spawn on some planets, can be lethal
crystal goliath: 10k, likely less lethal than the crystal legion but
still dangerous
mega arachnid, 8k, Appears in one ruin as a miniboss, rare enough it'd
be something to peek at
forgotten watcher: 6k, rare but relatively harmless compared to the
other crystal mobs (unless I'm missing something)
watcher variants: 4k, uncommon subspecies of watchers
ancient goliath: 4k, it's a remarkably old goliath, probably some value
there

## Why It's Good For The Game

Five. Hundred. Human bodies. In my medbay.

## Changelog

:cl:
add: ancient goliaths, crystal fauna (aside from legion), elites and
megafauna now have boosted dissection outputs
del: human corpses, podpeople, jellypeople and animal corpses can no
longer be dissected. What did you expect to find, an extra pair of
lungs?
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Theos <[email protected]>
Co-authored-by: Mark Suckerberg <[email protected]>
@SomeguyManperson SomeguyManperson deleted the patch-2 branch May 21, 2024 01:17
@SomeguyManperson SomeguyManperson mentioned this pull request Sep 16, 2024
2 tasks
trazodont added a commit to trazodont/Borktest that referenced this pull request Sep 19, 2024
trazodont added a commit to trazodont/Borktest that referenced this pull request Sep 19, 2024
trazodont added a commit to trazodont/Borktest that referenced this pull request Sep 19, 2024
trazodont added a commit to trazodont/Borktest that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants