Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ashwalker Shrine Remap #2931

Merged
merged 17 commits into from
Jun 6, 2024
Merged

Conversation

Zevotech
Copy link
Contributor

About The Pull Request

Completely remaps Ashwalker_Shrine into a new map: The Buried Shrine.
An unknown temple buried and ruined by volcanic activity. Who it belonged to before it was destroyed is unknown, but some of their riches yet remain buried inside. (Note, this is distinctly Not The Necropolis, and not explicitly ashwalker in origin. The walls have been renamed to represent this.)

SDMM:
StrongDMM-2024-04-23 22 37 23
StrongDMM-2024-04-23 22 37 24

Ingame:
image
(Fun fact: See those tiles in the lava? They sink when you walk over them and come back up after a few seconds. Good luck! :])

Why It's Good For The Game

Redone lavaland ruins that don't suck are good. This PR has the added benefit of making the formerly necropolis walls not strictly necropolis related due to its dubious chances at remaining in the lore. They're good looking walls.

Changelog

🆑
add: remapped and renamed ashwalker_shrine into lavaland_surface_buried_shrine
add: Necropolis walls have been renamed to thick stone walls.
/:cl:

@Zevotech Zevotech requested a review from a team as a code owner April 24, 2024 02:55
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Apr 24, 2024
@Latentish
Copy link
Member

Holy ship this ruin is poppin'. Let's test it.

@FalloutFalcon FalloutFalcon added the Ruin Ruin successfully tested. label May 24, 2024
@rye-rice rye-rice added this pull request to the merge queue Jun 2, 2024
Copy link
Contributor

github-actions bot commented Jun 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jun 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 2, 2024
@rye-rice rye-rice enabled auto-merge June 2, 2024 06:29
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jun 6, 2024
@Zevotech Zevotech disabled auto-merge June 6, 2024 03:16
@rye-rice rye-rice added this pull request to the merge queue Jun 6, 2024
Merged via the queue into shiptest-ss13:master with commit 4dde7ad Jun 6, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

Completely remaps Ashwalker_Shrine into a new map: The Buried Shrine.
An unknown temple buried and ruined by volcanic activity. Who it
belonged to before it was destroyed is unknown, but some of their riches
yet remain buried inside. (Note, this is distinctly **Not** The
Necropolis, and not *explicitly* ashwalker in origin. The walls have
been renamed to represent this.)

SDMM:
![StrongDMM-2024-04-23 22 37
23](https://github.com/shiptest-ss13/Shiptest/assets/95449138/2dcf4e18-7278-423b-9bfa-a13fc3972dcf)
![StrongDMM-2024-04-23 22 37
24](https://github.com/shiptest-ss13/Shiptest/assets/95449138/efdc9fca-c9bd-44dd-b103-c0bf3a3fb712)

Ingame:

![image](https://github.com/shiptest-ss13/Shiptest/assets/95449138/bd997ac3-6de6-40a4-a23a-8fd4cd34296b)
(Fun fact: See those tiles in the lava? They sink when you walk over
them and come back up after a few seconds. Good luck! :])
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Redone lavaland ruins that don't suck are good. This PR has the added
benefit of making the formerly necropolis walls not *strictly*
necropolis related due to its dubious chances at remaining in the lore.
They're good looking walls.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
add: remapped and renamed ashwalker_shrine into
lavaland_surface_buried_shrine
add: Necropolis walls have been renamed to thick stone walls.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants