Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes elzu multitool and emag interaction #2993

Merged

Conversation

Gristlebee
Copy link
Contributor

About The Pull Request

Removes the color changing interaction elzu have with multitools and emags.

Why It's Good For The Game

image

Thgvr asked me too

Changelog

🆑
del: Elzu can no longer change their color with the multitool or emag.
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label May 15, 2024
@tiramisuapimancer
Copy link
Contributor

tiramisuapimancer commented May 15, 2024

i wrote the elzu lore and it fits them perfectly, thg is wrong about removing it

@thgvr
Copy link
Member

thgvr commented May 15, 2024

i'd like to differentiate them from tg ethereals and have the choice of your color actually matter.

@Hlscientist
Copy link

but... how will I bully my ezlu friends, this is so sad.

@tiramisuapimancer
Copy link
Contributor

Multitool licking isn't actually a feature for tg ethereals- it was added in Whitesands. TG also has some sort of lore around what color your ethereal is that I'm not too clear on, but either way for them it isn't mutable the way an elzu's frequency is.

@FalloutFalcon FalloutFalcon added this pull request to the merge queue May 27, 2024
Merged via the queue into shiptest-ss13:master with commit ea57239 May 28, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jun 1, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Removes the color changing interaction elzu have with multitools and
emags.

## Why It's Good For The Game


![image](https://github.com/shiptest-ss13/Shiptest/assets/56049844/b81646c9-1490-46ad-88ea-ec5b08b0d6ad)

Thgvr asked me too

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
del: Elzu can no longer change their color with the multitool or emag.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
github-merge-queue bot pushed a commit that referenced this pull request Jun 2, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
To be merged after #2993.
Adds a Kalixcian beauty product that allows Elzuose to (temporarily (for
the duration of the round or until used again)) change their glow color.
Available in the loadout next to hair dye.


https://github.com/shiptest-ss13/Shiptest/assets/95449138/01060ea1-4b6b-490f-9bf2-83b69cf7efd7


<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
People wanted to keep the ability to change the glow color of an elzuose
using an item. Fits better than just using a multitool without the
potential for grief/shenanigans. Lore approved too!
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Adds the Elzuose color salve, a product that allows Elzuose to
change their glow color upon application.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

To be merged after shiptest-ss13#2993.
Adds a Kalixcian beauty product that allows Elzuose to (temporarily (for
the duration of the round or until used again)) change their glow color.
Available in the loadout next to hair dye.

https://github.com/shiptest-ss13/Shiptest/assets/95449138/01060ea1-4b6b-490f-9bf2-83b69cf7efd7

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

People wanted to keep the ability to change the glow color of an elzuose
using an item. Fits better than just using a multitool without the
potential for grief/shenanigans. Lore approved too!
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
add: Adds the Elzuose color salve, a product that allows Elzuose to
change their glow color upon application.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants