Hallucinations Fixes & Tweaks #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
Kapu1178
reviewed
May 23, 2024
their original (broken) behavior. Oops.
|
Ready for re-review! |
FalloutFalcon
approved these changes
May 28, 2024
shiptest-server
pushed a commit
that referenced
this pull request
May 31, 2024
Merged
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Jun 1, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This PR resolves shiptest-ss13#1500, finally allowing delusions to pass without the player having to relog (Big thanks to GenericDM and Theos for the help here!) This PR also changes the pool of delusions to be better suited towards Shiptest's sensibilities. Lastly, this PR ports BeeStation/BeeStation-Hornet#10421, hopefully allowing RDS to be treatable in-game again! <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game These bugs have been haunting RDS players for nearly two years straight. I want it GONE. Plus, narrative consistency good. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: fix: rds based delusions now pass without the player having to relog, thank god fix: rds can once again be treated with mindbreaker toxin (hopefully) tweak: the pool of possible delusions has been changed to better reflect shiptest's narrative add: a base ramzi sprite to simple_human.dmi to be used in the changed delusion pool del: chat warning message for rds users not to grief. Just be cool about it, okay? /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request A small followup to #3017, this considerably slows the metabolism on chemical mindbreaker. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> With the old implementation, chemical mindbreaker could hardly be used to treat RDS. A 50u dose would last only a few minutes, and destroy your liver in the process. This makes RDS actually viable to treat. Also, if you're taking chemical mindbreaker recreationally, you naughty dog you, this allows you the chance to hallucinate for more than a brief moment, given how hallucinations are weighted. Not a very useful recreational substance if it exits your system within thirty seconds. ## Changelog :cl: balance: chemical mindbreaker is now ten times as potent! Be gay, do crime, and hallucinate in the process /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> A small followup to shiptest-ss13#3017, this considerably slows the metabolism on chemical mindbreaker. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> With the old implementation, chemical mindbreaker could hardly be used to treat RDS. A 50u dose would last only a few minutes, and destroy your liver in the process. This makes RDS actually viable to treat. Also, if you're taking chemical mindbreaker recreationally, you naughty dog you, this allows you the chance to hallucinate for more than a brief moment, given how hallucinations are weighted. Not a very useful recreational substance if it exits your system within thirty seconds. :cl: balance: chemical mindbreaker is now ten times as potent! Be gay, do crime, and hallucinate in the process /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR resolves #1500, finally allowing delusions to pass without the player having to relog (Big thanks to GenericDM and Theos for the help here!)
This PR also changes the pool of delusions to be better suited towards Shiptest's sensibilities.
Lastly, this PR ports BeeStation/BeeStation-Hornet#10421, hopefully allowing RDS to be treatable in-game again!
Why It's Good For The Game
These bugs have been haunting RDS players for nearly two years straight. I want it GONE. Plus, narrative consistency good.
Changelog
🆑
fix: rds based delusions now pass without the player having to relog, thank god
fix: rds can once again be treated with mindbreaker toxin (hopefully)
tweak: the pool of possible delusions has been changed to better reflect shiptest's narrative
add: a base ramzi sprite to simple_human.dmi to be used in the changed delusion pool
del: chat warning message for rds users not to grief. Just be cool about it, okay?
/:cl: