Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increases the price of automatic weapons and some handguns #3111

Merged
merged 9 commits into from
Jul 16, 2024

Conversation

Martinpachu
Copy link
Contributor

About The Pull Request

Self explanatory. Also slightly nerfs the price on pistols to make them more balanced compared to revolvers.

Why It's Good For The Game

Automatics are EXTREMELY powerful and it's supposed to be a big deal to equip everyone or most people in a crew with them. ESPECIALLY AR's. Pistols one is more to just make revolvers more viable.

Changelog

🆑

balance: Doubled the price on every automatic gun and added 250 credits to the price of every semi-auto pistol.
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Jun 16, 2024
@generalthrax
Copy link
Contributor

Might want to increase mech price while you're at it. iirc as it stands a full Gygax DIY kit is just 2000 more than a P16 or SKM

@Gristlebee
Copy link
Contributor

Might want to increase mech price while you're at it. iirc as it stands a full Gygax DIY kit is just 2000 more than a P16 or SKM

Yep, Gygax is 12k at the outpost, but you do still have to buy equipment for the mech as well, which is usually another couple thousand on average.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jun 24, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jun 24, 2024
Martinpachu and others added 2 commits June 29, 2024 21:13
@thgvr thgvr changed the title Nerfs the price on automatic weapons. Increases the price of automatic weapons and some handguns Jul 12, 2024
@rye-rice rye-rice added the Test Merge Required They'll have to do it for free. label Jul 13, 2024
@thgvr thgvr added this pull request to the merge queue Jul 16, 2024
Merged via the queue into shiptest-ss13:master with commit 332e118 Jul 16, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jul 20, 2024
…ss13#3111)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

Self explanatory. Also slightly nerfs the price on pistols to make them
more balanced compared to revolvers.

Automatics are EXTREMELY powerful and it's supposed to be a big deal to
equip everyone or most people in a crew with them. ESPECIALLY AR's.
Pistols one is more to just make revolvers more viable.

:cl:

balance: Doubled the price on every automatic gun and added 250 credits
to the price of every semi-auto pistol.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Martinpachu <[email protected]>
Co-authored-by: Theos <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jul 23, 2024
…3223)

## About The Pull Request

Reverts #3111 as it was
awaiting testmerges for being a Very Unpopular pr among maintainers and
other voices in private-dev (extensively discussed) before it was
full-merged without that happening.

## Why It's Good For The Game

Lol

![woe2](https://github.com/user-attachments/assets/94c29def-6fe8-4bad-8b72-e66af04276fd)

## Changelog

:cl:
balance: Undoubles the price on every automatic gun and removed 250 from
the price of every semi-auto pistol.
/:cl:
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jul 27, 2024
…hiptest-ss13#3223)

Reverts shiptest-ss13#3111 as it was
awaiting testmerges for being a Very Unpopular pr among maintainers and
other voices in private-dev (extensively discussed) before it was
full-merged without that happening.

Lol

![woe2](https://github.com/user-attachments/assets/94c29def-6fe8-4bad-8b72-e66af04276fd)

:cl:
balance: Undoubles the price on every automatic gun and removed 250 from
the price of every semi-auto pistol.
/:cl:
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
…ss13#3111)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Self explanatory. Also slightly nerfs the price on pistols to make them
more balanced compared to revolvers.

## Why It's Good For The Game

Automatics are EXTREMELY powerful and it's supposed to be a big deal to
equip everyone or most people in a crew with them. ESPECIALLY AR's.
Pistols one is more to just make revolvers more viable.

## Changelog

:cl:

balance: Doubled the price on every automatic gun and added 250 credits
to the price of every semi-auto pistol.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Martinpachu <[email protected]>
Co-authored-by: Theos <[email protected]>
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
…hiptest-ss13#3223)

## About The Pull Request

Reverts shiptest-ss13#3111 as it was
awaiting testmerges for being a Very Unpopular pr among maintainers and
other voices in private-dev (extensively discussed) before it was
full-merged without that happening.

## Why It's Good For The Game

Lol

![woe2](https://github.com/user-attachments/assets/94c29def-6fe8-4bad-8b72-e66af04276fd)

## Changelog

:cl:
balance: Undoubles the price on every automatic gun and removed 250 from
the price of every semi-auto pistol.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants