Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces ship spawn limit for everything to 1 #3166

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

Apogee-dev
Copy link
Contributor

@Apogee-dev Apogee-dev commented Jun 28, 2024

About The Pull Request

Reduces the spawn limit for every ship to 1, and makes the default limit for new ships 1.

Why It's Good For The Game

Nearly every ship was already set to a limit of 1. Making it the default just saves time. Most of the handful of ships that still had a cap of 2- mudskipper, li tieguai, and delta, for instance - were ships that would just compete for pop or nudge each other out of their niche if double-spawned, and a greater variety of ships are available to accept players after existing ones fill up than there previously were.

Changelog

🆑
balance: reduced default ship spawn limit to 1.
/:cl:

@Apogee-dev Apogee-dev requested a review from a team as a code owner June 28, 2024 19:58
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Jun 28, 2024
@SomeguyManperson
Copy link
Contributor

The mudskipper has about the same crew compliment as a kilo and is only picked more often because it has an interior space larger than five rooms full of goop

@Apogee-dev
Copy link
Contributor Author

The mudskipper has about the same crew compliment as a kilo and is only picked more often because it has an interior space larger than five rooms full of goop

yeah exactly. the mudskipper has the same crew complement, but it's better equipped. it should have the same limit as literally everything else that isn't the kilo, including other ships with crews smaller than 10 players (vaquero, delta, etc)

@generalthrax
Copy link
Contributor

generalthrax commented Jun 28, 2024

Might wanna change spawn limit of the Li Tieguai and Shetland to 1 while you're at it.

@Apogee-dev
Copy link
Contributor Author

Apogee-dev commented Jun 28, 2024

Might wanna change spawn limit of the Li Tieguai and Shetland to 1 while you're at it.

good point yeah. Shit, I'll make the default limit 1 and just set kilo to 2. Almost every ship has a limit of 1 anyway, it makes more sense to make that the default.

@Apogee-dev Apogee-dev changed the title Reduces spawn limit for the Mudskipper Reduces ship spawn limit for everything but Kilo to 1 Jun 28, 2024
@Apogee-dev
Copy link
Contributor Author

Updated the PR description and title to account for the expanded scope.

@FalloutFalcon
Copy link
Member

Having a ship limit per amount of people connected might be a good idea down the line.
Say you set it at 30 people so once we pass 60 it opens another mudskipper slot or something like that.

I honestly think every ship can be 1 right now. I don't see the reason for the exception.

@FalloutFalcon
Copy link
Member

And keep in mind.. people can still just ahelp for another mudskipper or kilo slot if we are high pop... I will miss the low pop two mudskippers with a combined 3 crew

@Apogee-dev
Copy link
Contributor Author

Yeah fair enough, I'll cut the exception for the Kilo

@Apogee-dev Apogee-dev changed the title Reduces ship spawn limit for everything but Kilo to 1 Reduces ship spawn limit for everything to 1 Jul 1, 2024
@rye-rice rye-rice added this pull request to the merge queue Jul 8, 2024
Merged via the queue into shiptest-ss13:master with commit 45326f2 Jul 8, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jul 10, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Reduces the spawn limit for every ship to 1, and makes the default limit
for new ships 1.

## Why It's Good For The Game

Nearly every ship was already set to a limit of 1. Making it the default
just saves time. Most of the handful of ships that still had a cap of 2-
mudskipper, li tieguai, and delta, for instance - were ships that would
just compete for pop or nudge each other out of their niche if
double-spawned, and a greater variety of ships are available to accept
players after existing ones fill up than there previously were.

## Changelog

:cl:
balance: reduced default ship spawn limit to 1.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Reduces the spawn limit for every ship to 1, and makes the default limit
for new ships 1.

## Why It's Good For The Game

Nearly every ship was already set to a limit of 1. Making it the default
just saves time. Most of the handful of ships that still had a cap of 2-
mudskipper, li tieguai, and delta, for instance - were ships that would
just compete for pop or nudge each other out of their niche if
double-spawned, and a greater variety of ships are available to accept
players after existing ones fill up than there previously were.

## Changelog

:cl:
balance: reduced default ship spawn limit to 1.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants