The Particlening #3239
Merged
The Particlening #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
|
I already gave my opinion about the gibbing changes on discord but I’ll repeat them here: I think it’s a move in the wrong direction. All the sources of gibbing in the game are rare, predictable, or player-initiated. If implanting brains into legion corpses is unbelievable and jank, I’d rather remove brain implanting entirely (it’s kind of absurd that random miners working out of a space ship’s bathroom can technically pull that off anyway). Require an MMI to save somebody who’s been debrained or something. That, and leaving everything intact but scattered around sort of defeats the point of gibbing anyway, given it specifically represents somebody getting the business end of the chunky salsa rule, not neatly dismembered. |
|
Particle updates are great. This has no reason to be bundled with the gibbing change though |
|
As a note, I believe the bone breaking sounds here cause people to crash when they play, depending on the version of BYOND they have installed. Not sure why- wish I could be more helpful here, sorry. https://i.imgur.com/c9zeSqP.png pic of it happening to me, cloudbreak mentioned it happening a few times as well |
thgvr
reviewed
Jul 25, 2024
|
|
||
| /datum/looping_sound/weather/rain/storm | ||
| mid_sounds = list( | ||
| 'sound/ambience/storm_outdoors.ogg' = 1 |
There was a problem hiding this comment.
Suggested change
| 'sound/ambience/storm_outdoors.ogg' = 1 | |
| 'sound/ambience/storm_outdoors.ogg' = 1, |
code/modules/mob/living/blood.dm
Outdated
| if(4 to INFINITY) | ||
| bleeeding_wording = "<b>Your heartbeat beats extremely and unstably fast as you lose a massive amount of blood!!</b>" | ||
|
|
||
| /* how bleeding works has changed, this is now useless |
| addtimer(CALLBACK(src, PROC_REF(break_bone_feedback), 1 SECONDS)) | ||
|
|
||
| /obj/item/bodypart/proc/break_bone_feedback() | ||
| owner.visible_message("<span class='danger'>You hear a cracking sound coming from [owner]'s [name].</span>", "<span class='userdanger'>You feel something crack in your [name]!</span>", "<span class='danger'>You hear an awful cracking sound.</span>") |
|
|
||
| /obj/item/bodypart/proc/break_bone_feedback() | ||
| owner.visible_message("<span class='danger'>You hear a cracking sound coming from [owner]'s [name].</span>", "<span class='userdanger'>You feel something crack in your [name]!</span>", "<span class='danger'>You hear an awful cracking sound.</span>") | ||
| playsound(owner, list('sound/health/bone/bone_break1.ogg','sound/health/bone/bone_break2.ogg','sound/health/bone/bone_break3.ogg','sound/health/bone/bone_break4.ogg','sound/health/bone/bone_break5.ogg','sound/health/bone/bone_break6.ogg'), 100, FALSE, -1) |
There was a problem hiding this comment.
This is probably what is causing issues, maybe something about file access idk
thgvr
previously requested changes
Jul 26, 2024
|
Lava particles can be grabbed by gravitational anomalies and flung around, which looks quite silly. |
|
We can merge this once you take out the gibbing change that leaves a torso behind |
|
apologies for the delay in removing the anti-salt measure, got distracted by a fucking butterfly; lgtm, etc |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shiptest-server
pushed a commit
that referenced
this pull request
Aug 26, 2024
Constellado
pushed a commit
to Constellado/PentestOld
that referenced
this pull request
Aug 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Fixes shiptest-ss13#1793 This adds a fuck ton of particles to the game. These are almost entirely ported from tgstation, specifically: tgstation/tgstation#71110 (I was unable to get the editor to work, so this is just the backend fancy stuff) tgstation/tgstation#59869 (particles) tgstation/tgstation#60515 (particles) tgstation/tgstation#74555 (particles) And because atomization is not in my name, I have also done added my own spin on this, and that is making blood show up as a particle effect, instead of mysteriously showing up on the floor. I also made the mysteriously showing up on the floor bit more clearer if you are spilling a lot of blood. Because of the above, I went further and ported DaedalusDock/daedalusdock#79 (blood squirts only) as well for being shot, and some additions I made myself. I am aware using sleep() is bad practice, but I'm not sure how I would avoid using it here outside of rearranging how a lot of things work, so ill just say its "fine" Also gibbing doesn't destroy your body anymore, however it STILL will be very hard to fix you reguardless, since you still fall apart like a lego character, it's just you no longer need to stuff them into a legion corpse. And during testing since it annoyed me, bloodloss effects are more pronounced and harder to ignore, taken mostly from https://github.com/tgstation/TerraGov-Marine-Corps 's bloodloss effects but less severe in a way. And one last thing, bone breaking has sound effects, from Terragov above. Cronch. ## Why It's Good For The Game While i'm not convinced over using particles over hand drawn sprite effects, I cannot deny i see the potential in them, especially here!      ## Changelog :cl: Baystation12, Kapu1178, rye-rice add: Particles! add: Bleeding has better feedback add: Bone breaking now has sound effects add: Getting shot now throws blood squirts! Live through the somme for REAL this time! balance: gibbing no longer destroys your chest, no more legion transfers! fix: Lava particles should no longer destroy your FPS /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: retlaw34 <[email protected]>
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Sep 2, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Fixes shiptest-ss13#1793 This adds a fuck ton of particles to the game. These are almost entirely ported from tgstation, specifically: tgstation/tgstation#71110 (I was unable to get the editor to work, so this is just the backend fancy stuff) tgstation/tgstation#59869 (particles) tgstation/tgstation#60515 (particles) tgstation/tgstation#74555 (particles) And because atomization is not in my name, I have also done added my own spin on this, and that is making blood show up as a particle effect, instead of mysteriously showing up on the floor. I also made the mysteriously showing up on the floor bit more clearer if you are spilling a lot of blood. Because of the above, I went further and ported DaedalusDock/daedalusdock#79 (blood squirts only) as well for being shot, and some additions I made myself. I am aware using sleep() is bad practice, but I'm not sure how I would avoid using it here outside of rearranging how a lot of things work, so ill just say its "fine" Also gibbing doesn't destroy your body anymore, however it STILL will be very hard to fix you reguardless, since you still fall apart like a lego character, it's just you no longer need to stuff them into a legion corpse. And during testing since it annoyed me, bloodloss effects are more pronounced and harder to ignore, taken mostly from https://github.com/tgstation/TerraGov-Marine-Corps 's bloodloss effects but less severe in a way. And one last thing, bone breaking has sound effects, from Terragov above. Cronch. ## Why It's Good For The Game While i'm not convinced over using particles over hand drawn sprite effects, I cannot deny i see the potential in them, especially here!      ## Changelog :cl: Baystation12, Kapu1178, rye-rice add: Particles! add: Bleeding has better feedback add: Bone breaking now has sound effects add: Getting shot now throws blood squirts! Live through the somme for REAL this time! balance: gibbing no longer destroys your chest, no more legion transfers! fix: Lava particles should no longer destroy your FPS /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: retlaw34 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #1793
This adds a fuck ton of particles to the game. These are almost entirely ported from tgstation, specifically:
tgstation/tgstation#71110 (I was unable to get the editor to work, so this is just the backend fancy stuff)
tgstation/tgstation#59869 (particles)
tgstation/tgstation#60515 (particles)
tgstation/tgstation#74555 (particles)
And because atomization is not in my name, I have also done added my own spin on this, and that is making blood show up as a particle effect, instead of mysteriously showing up on the floor. I also made the mysteriously showing up on the floor bit more clearer if you are spilling a lot of blood.
Because of the above, I went further and ported DaedalusDock/daedalusdock#79 (blood squirts only) as well for being shot, and some additions I made myself. I am aware using sleep() is bad practice, but I'm not sure how I would avoid using it here outside of rearranging how a lot of things work, so ill just say its "fine"
Also gibbing doesn't destroy your body anymore, however it STILL will be very hard to fix you reguardless, since you still fall apart like a lego character, it's just you no longer need to stuff them into a legion corpse.
And during testing since it annoyed me, bloodloss effects are more pronounced and harder to ignore, taken mostly from https://github.com/tgstation/TerraGov-Marine-Corps 's bloodloss effects but less severe in a way.
And one last thing, bone breaking has sound effects, from Terragov above. Cronch.
Why It's Good For The Game
While i'm not convinced over using particles over hand drawn sprite effects, I cannot deny i see the potential in them, especially here!
Changelog
🆑 Baystation12, Kapu1178, rye-rice
add: Particles!
add: Bleeding has better feedback
add: Bone breaking now has sound effects
add: Getting shot now throws blood squirts! Live through the somme for REAL this time!
balance: gibbing no longer destroys your chest, no more legion transfers!
fix: Lava particles should no longer destroy your FPS
/:cl: