You can no longer phase through a flipped table. #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiptest-server
pushed a commit
that referenced
this pull request
Aug 17, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Aug 19, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Flipped tables had an issue where they didnt block movement properly from it's outward side, or it's inward if you flipped it while diagonal. Adds an extra proc to help check the directions and fixes the other checks so people can't occasionally phase directly through a flipped table. Also adds an examine hint to flipped tables on how to right them, and changes the span classes to macros ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> Bugfixes are good. ## Changelog :cl: add: Examine hints for flipped tables fix: You can no longer phase through a flipped table. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Constellado
pushed a commit
to Constellado/PentestOld
that referenced
this pull request
Aug 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Flipped tables had an issue where they didnt block movement properly from it's outward side, or it's inward if you flipped it while diagonal. Adds an extra proc to help check the directions and fixes the other checks so people can't occasionally phase directly through a flipped table. Also adds an examine hint to flipped tables on how to right them, and changes the span classes to macros ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> Bugfixes are good. ## Changelog :cl: add: Examine hints for flipped tables fix: You can no longer phase through a flipped table. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Flipped tables had an issue where they didnt block movement properly from it's outward side, or it's inward if you flipped it while diagonal.
Adds an extra proc to help check the directions and fixes the other checks so people can't occasionally phase directly through a flipped table.
Also adds an examine hint to flipped tables on how to right them, and changes the span classes to macros
Why It's Good For The Game
Bugfixes are good.
Changelog
🆑
add: Examine hints for flipped tables
fix: You can no longer phase through a flipped table.
/:cl: