Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scarab-class Heavy Mining Ship #3380

Merged
merged 51 commits into from
Oct 26, 2024
Merged

Conversation

Sadhorizon
Copy link
Contributor

@Sadhorizon Sadhorizon commented Sep 16, 2024

About The Pull Request

New ship, hooray!
This one is kinda quirky - it's a mining ship, but without any miners. It's main focus is on the drilling mechanic, which means it has extended engineering and security.

TODO:

  • fix the airlock in the back for the most part, it works. It's as broken as the AACs are.
  • desc
  • get the ballistic goggles in
  • Do the bridge again.
  • Newscasters
Screenshots:

scrnshot1

StrongDMM-2024-10-17 16 26 54

StrongDMM-2024-10-17 16 26 56

Main features:

  • Roundstart drill.
  • A Talos-style maint that can be used for engineering projects.
  • Strong guns for an indie ship - 1 Indie Cobra, 1 HP Hellfire, 2 HP Detective Specials.
  • Roundstart angle grinders.

Crew manifest:

  • 1x Captain
  • 1x Foreman
  • 2x Technician
  • 2x Security Detail
  • 2x Deckhand

Desc revised by apogee <3

Why It's Good For The Game

This ship gives indies three new niches at once: drilling focus, engineering focus, potential for some sec gimmicks. Also has gear for salvaging.
Also gives indies a Hardline ship at last.

Changelog

🆑
add: Added the Scarab-class Heavy Mining Ship
/:cl:

@Sadhorizon Sadhorizon requested a review from a team as a code owner September 16, 2024 20:59
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Sep 16, 2024
@Apogee-dev
Copy link
Contributor

Apogee-dev commented Sep 17, 2024

Minor note, but "clipper" feels sort of unfitting for this class, mining ship that she is. Historically the word referred to merchant ships designed to go as fast as possible while carrying a decent cargo, and a big chunky rig miner is almost the polar opposite. Something like "heavy mining vessel" or "drilling ship" might do the trick instead.

@Sadhorizon Sadhorizon changed the title Adds a new indie ship - the Scarab-class. Adds a new indie ship - the Scarab-class Heavy Mining Ship. Sep 17, 2024
@FalloutFalcon FalloutFalcon added the Ship Ship successfully tested. label Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 20, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![obraz](https://github.com/user-attachments/assets/b7840360-db17-42e5-8c23-d161e59acf8f)
Woah! Best sprite showcase of 2024!


Note: Those goggles, unlike the ones that factions have, do NOT have a
sechud. They are just fancy sunglasses.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
- Probably good to have them seperated, just like how inteq did it.
- Indie sec drip.
- I REALLY want this for the #3380.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Added "ballistic goggles" - new indie security clothing item.
imageadd: Added Kepori bulletproof helmet sprites.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Sep 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![obraz](https://github.com/user-attachments/assets/b7840360-db17-42e5-8c23-d161e59acf8f)
Woah! Best sprite showcase of 2024!


Note: Those goggles, unlike the ones that factions have, do NOT have a
sechud. They are just fancy sunglasses.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
- Probably good to have them seperated, just like how inteq did it.
- Indie sec drip.
- I REALLY want this for the shiptest-ss13#3380.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Added "ballistic goggles" - new indie security clothing item.
imageadd: Added Kepori bulletproof helmet sprites.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@Sadhorizon
Copy link
Contributor Author

Sadhorizon commented Oct 5, 2024

I assume the intent is something similar to the loading door for the smelter on the Delta, though as far as I can tell there's no switch to open it. There's also the fact the main airlock is there right above it, making it rather redundant. I'd prefer if replaced the you door with another wall.

It's a maintenance door in case belts get fucky wucky. Can't really deconstruct the smelter stuff rn so I figured it's the second best. Very much an edge case, but I think it makes sense lore-wise.

I'd suggest adding a captain's duster to the captain's locker for parity with other indie vessels.

I do not want them to have a western aesthetic. They are industrial-people, not cowboys.

@Gristlebee
Copy link
Contributor

It's a maintenance door in case belts get fucky wucky. Can't really deconstruct the smelter stuff rn so I figured it's the second best.
I do not want them to have a western aesthetic. They are industrial-people, not cowboys.

That's fair enough. It can be kept as is.

Copy link
Contributor

@Gristlebee Gristlebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback after testing on live:

Ship worked great on live, but there's a couple concerns.

The power flow console here is capable of accessing APCs on other ships which is a concern. Swap it out for a power monitor console instead.
image

Cargo orders are able to drop onto the ore processing belts. There is the maintenance door to grab it, but that still isn't great. I'd suggest giving it its own separate area from the cargo bay, though if you have any other solutions in mind, that's fine as well.

I'd suggest linking the maintenance door for the ore belts to an access locked button on the foreman's desk or the bridge. It feels a bit odd to need to hack it open in order to fix your ship.

The way the cycle airlock is set up in the rear can have it's plating ripped up due to pressure differentials from not decompressing first.

The large airlock means it's also using a lot of air to cycle. It eats through the ship's distro pretty rapidly. I'd recommend adding a regular canister of air for refilling in a pinch.

@Sadhorizon
Copy link
Contributor Author

I'd suggest linking the maintenance door for the ore belts to an access locked button on the foreman's desk or the bridge. It feels a bit odd to need to hack it open in order to fix your ship.

Nah. Fixing that part would be too rare to warrant a button. I think you say that because your cargo orders got stuck there, which is 100% an oversight.

Rest I'll fix later.

@Sadhorizon Sadhorizon changed the title Adds a new indie ship - the Scarab-class Heavy Mining Ship. Scarab-class Heavy Mining Ship Oct 24, 2024
@Apogee-dev Apogee-dev added this pull request to the merge queue Oct 26, 2024
@Apogee-dev
Copy link
Contributor

Good to go, send it.

Merged via the queue into shiptest-ss13:master with commit e52547f Oct 26, 2024
14 checks passed
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
New ship, hooray!
This one is kinda quirky - it's a mining ship, but without any miners.
It's main focus is on the drilling mechanic, which means it has extended
engineering and security.

**TODO:**
- [x] ~~fix the airlock in the back~~ for the most part, it works. It's
as broken as the AACs are.
- [x] desc
- [x] get the ballistic goggles in
- [x] Do the bridge again.
- [x] Newscasters 

<details><summary>Screenshots:</summary>
<p>


![scrnshot1](https://github.com/user-attachments/assets/7aab5f85-9ebc-4563-ac63-3875f8e3177a)

![StrongDMM-2024-10-17 16 26
54](https://github.com/user-attachments/assets/ae47312c-8e09-4216-afa1-9c5abc64eb9d)

![StrongDMM-2024-10-17 16 26
56](https://github.com/user-attachments/assets/2ff18d92-2952-44b9-8be1-9ba863652b5a)

</p>
</details> 

Main features:
- Roundstart drill.
- A Talos-style maint that can be used for engineering projects.
- Strong guns for an indie ship - 1 Indie Cobra, 1 HP Hellfire, 2 HP
Detective Specials.
- Roundstart angle grinders.

Crew manifest:
- 1x Captain
- 1x Foreman
- 2x Technician
- 2x Security Detail
- 2x Deckhand

Desc revised by apogee <3
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
This ship gives indies three new niches at once: drilling focus,
engineering focus, potential for some sec gimmicks. Also has gear for
salvaging.
Also gives indies a Hardline ship at last.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Added the Scarab-class Heavy Mining Ship
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 24, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

![obraz](https://github.com/user-attachments/assets/b7840360-db17-42e5-8c23-d161e59acf8f)
Woah! Best sprite showcase of 2024!

Note: Those goggles, unlike the ones that factions have, do NOT have a
sechud. They are just fancy sunglasses.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
- Probably good to have them seperated, just like how inteq did it.
- Indie sec drip.
- I REALLY want this for the shiptest-ss13#3380.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
add: Added "ballistic goggles" - new indie security clothing item.
imageadd: Added Kepori bulletproof helmet sprites.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants