Reduces the chance for grenades to go off in your hands #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FalloutFalcon
previously requested changes
Sep 26, 2024
| @@ -150,7 +150,7 @@ | |||
|
|
|||
| /obj/item/grenade/hit_reaction(mob/living/carbon/human/owner, atom/movable/hitby, attack_text = "the attack", final_block_chance = 0, damage = 0, attack_type = MELEE_ATTACK) | |||
| var/obj/projectile/P = hitby | |||
| if(damage && attack_type == PROJECTILE_ATTACK && P.damage_type != STAMINA && prob(15)) | |||
| if(damage && attack_type == PROJECTILE_ATTACK && P.damage_type != STAMINA && prob(1) && prob(50)) | |||
There was a problem hiding this comment.
Suggested change
| if(damage && attack_type == PROJECTILE_ATTACK && P.damage_type != STAMINA && prob(1) && prob(50)) | |
| if(damage && attack_type == PROJECTILE_ATTACK && P.damage_type != STAMINA && prob(0.5)) |
There was a problem hiding this comment.
Oh, thank you! I wasn't sure if the argument only took integers or if it took floats, so I just did it like this to ensure that it worked. I'll fix this, thank you.
There was a problem hiding this comment.
The modification should be complete now
|
Honestly this should just be a chance that rolls for each projectile that hits that specific arm rather than the player in general. 15% would make a lot more sense if that were the case. |
|
I'll try and implement that. I will say, however, I'd prefer if the probability were still reduced down to, say, 2-5% even with this change, as bullets can hit limbs just from natural spread, and with the current probability calculation, the chance of it going off would still be fairly high, if it were kept at 15%. |
I've implemented a check to see if a projectile hits an arm holding a grenade, and I also set the probability to 5% for this. Please let me know if this looks okay? Thank you. |
shiptest-server
pushed a commit
that referenced
this pull request
Oct 15, 2024
zimon9
added a commit
to zimon9/Shiptest-PR-testing
that referenced
this pull request
Oct 29, 2024
…3#3441) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This change reduces the probability of a grenade blowing up in one's hands from 15% down to 5%. Please let me know if this probability is too low. I just chose an oddball low number to use. The check was also modified so that the dice roll is only made if a projectile hits a hand holding a grenade. ## Why It's Good For The Game It always felt a little too high of a chance to me. The probability roll happens for _each_ projectile that one gets hit with, and with how often and how rapidly one can be hit in a firefight here, the chance of it blowing up in ones hands goes from being somewhat unlikely to being more likely to happen than not.  This calculator gives the probability of the event occurring as being 68% likely, if one were shot 7 times. This is around how many shots it takes to bring someone down, on average, from my anecdotal experience. This currently has the effect of making grenades useful in only a few very specific scenarios. If the probability of this were to go down, it would encourage the use of grenades more, which I feel can enhance fights. ## Changelog :cl: balance: rebalanced the probability of a grenade going off in one's hands /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
zimon9
pushed a commit
to zimon9/Shiptest-PR-testing
that referenced
this pull request
Oct 29, 2024
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Dec 27, 2024
…3#3441) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This change reduces the probability of a grenade blowing up in one's hands from 15% down to 5%. Please let me know if this probability is too low. I just chose an oddball low number to use. The check was also modified so that the dice roll is only made if a projectile hits a hand holding a grenade. ## Why It's Good For The Game It always felt a little too high of a chance to me. The probability roll happens for _each_ projectile that one gets hit with, and with how often and how rapidly one can be hit in a firefight here, the chance of it blowing up in ones hands goes from being somewhat unlikely to being more likely to happen than not.  This calculator gives the probability of the event occurring as being 68% likely, if one were shot 7 times. This is around how many shots it takes to bring someone down, on average, from my anecdotal experience. This currently has the effect of making grenades useful in only a few very specific scenarios. If the probability of this were to go down, it would encourage the use of grenades more, which I feel can enhance fights. ## Changelog :cl: balance: rebalanced the probability of a grenade going off in one's hands /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This change reduces the probability of a grenade blowing up in one's hands from 15% down to 5%.
Please let me know if this probability is too low. I just chose an oddball low number to use.
The check was also modified so that the dice roll is only made if a projectile hits a hand holding a grenade.
Why It's Good For The Game
It always felt a little too high of a chance to me. The probability roll happens for each projectile that one gets hit with, and with how often and how rapidly one can be hit in a firefight here, the chance of it blowing up in ones hands goes from being somewhat unlikely to being more likely to happen than not.
This calculator gives the probability of the event occurring as being 68% likely, if one were shot 7 times. This is around how many shots it takes to bring someone down, on average, from my anecdotal experience.
This currently has the effect of making grenades useful in only a few very specific scenarios.
If the probability of this were to go down, it would encourage the use of grenades more, which I feel can enhance fights.
Changelog
🆑
balance: rebalanced the probability of a grenade going off in one's hands
/:cl: