Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

click cooldown hud #3461

Merged
merged 2 commits into from
Nov 3, 2024
Merged

click cooldown hud #3461

merged 2 commits into from
Nov 3, 2024

Conversation

FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Sep 29, 2024

About The Pull Request

A port of this pr
DaedalusDock/daedalusdock#732

Adds a bar to the bottom of the screen that shows click cooldown
https://github.com/user-attachments/assets/8824ba1a-2596-4dcf-ae16-2dafdd380666

Why It's Good For The Game

I can tell when i can attack next

Changelog

🆑 FalloutFalcon, Kapu1178
add: New bar above your items to show your attack cooldown
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Sep 29, 2024
@Kapu1178
Copy link
Contributor

credit? DaedalusDock/daedalusdock#732

@FalloutFalcon
Copy link
Member Author

oops my bad it needs a real desc as well..

@FalloutFalcon FalloutFalcon added the Test Merge Required They'll have to do it for free. label Oct 5, 2024
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing this in game i dont think its the play to have even more shit on the hud, not to mention its kind of out of place, im not sure if players would need to have this information as well?

@FalloutFalcon
Copy link
Member Author

seeing this in game i dont think its the play to have even more shit on the hud, not to mention its kind of out of place, im not sure if players would need to have this information as well?

I think the first part is a little opinion based however its useful for anything that sets a strange cool-down, like a lot of resist style acts use a click cool-down of up to 10 seconds. However the real reason for this is for variable cool-down of melee weapons, think of it as a pre-req

@generalthrax
Copy link
Contributor

Pulling activates a cooldown, preventing you from clicking soon after. I'm not sure if this is new or not or if I'm just stupid.

@FalloutFalcon FalloutFalcon added Test Merged They've done it for free. and removed Test Merge Required They'll have to do it for free. labels Oct 16, 2024
@FalloutFalcon
Copy link
Member Author

Pulling activates a cooldown, preventing you from clicking soon after. I'm not sure if this is new or not or if I'm just stupid.

your silly. this is exactly the type of thing i want this for tho

@Sun-Soaked
Copy link
Member

Pulling activates a cooldown, preventing you from clicking soon after. I'm not sure if this is new or not or if I'm just stupid.

this is kind of indicative of why we need this feature, I think @rye-rice

Copy link
Member

@Sun-Soaked Sun-Soaked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. waiting for rye to respond before merging

@Sun-Soaked
Copy link
Member

Sun-Soaked commented Oct 24, 2024

We should make this feature optional, but it feels important enough to merge until someone makes that happen
considering how many players seemed to have 0 idea of how many click cooldowns worked until they saw them visualized

@thgvr
Copy link
Member

thgvr commented Oct 24, 2024

I dunno about optional. It needs better integration into HUD elements which we can't really do right now. Having this is actually a great QOL.

@Sun-Soaked
Copy link
Member

I dunno about optional. It needs better integration into HUD elements which we can't really do right now. Having this is actually a great QOL.

a new sprite would help, but till then.

@FalloutFalcon
Copy link
Member Author

rye requsted drafting it till i make it a toggle and add alternative sprites.

@FalloutFalcon FalloutFalcon marked this pull request as draft October 24, 2024 00:10
@FalloutFalcon
Copy link
Member Author

i forgot to do that.

@thgvr
Copy link
Member

thgvr commented Oct 24, 2024

something like this definitely shouldn't be a toggle - it's pretty core to how you interact with the game

@thgvr
Copy link
Member

thgvr commented Nov 3, 2024

We can come up with a new asset later as we rework hud elements, this is fine as is and a toggle isn't necessary (we talked about it)

@thgvr thgvr marked this pull request as ready for review November 3, 2024 10:29
@thgvr thgvr added this pull request to the merge queue Nov 3, 2024
Merged via the queue into shiptest-ss13:master with commit 6becd79 Nov 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Test Merged They've done it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants