Dynamic human icons #3462
Open
Dynamic human icons #3462
+409
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i will fix that unit test fail but its still good for tm |
FalloutFalcon
added
Test Merged
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…to dynamic-human-icons
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
fix conflicts and let's see if the, github checks segmentation fault. happens again (what the fuck) |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <details><summary>Pictures</summary> <p>      </p> </details> Adds a new ruin to the rockplanet pool. The N+S Mining Base is a small mining installation that had been built to extract minerals - and then was promptly raided by the Ramzi Clique (ramzi guys are somewhat waiting on #3462. I consider them placeholder right now). The ruin contains a small amount of weaponry, some fluff, and a refinery for your lovely ore mining efforts. The main gimmick is based around cleaning the base up, getting it somewhat functional, and using the drill to extract ore from the comically good ore veins. There are platforms with turrets deployed around them (as well as sandbags) to form a defensible position, but unless you can get into the refinery, it'll be somewhat annoying to actually use. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game It's gimmicky content!! <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: N+S has reported losing contact with one of their rockplanet based mining installations /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Erika Fox <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <details><summary>Pictures</summary> <p>      </p> </details> Adds a new ruin to the rockplanet pool. The N+S Mining Base is a small mining installation that had been built to extract minerals - and then was promptly raided by the Ramzi Clique (ramzi guys are somewhat waiting on #3462. I consider them placeholder right now). The ruin contains a small amount of weaponry, some fluff, and a refinery for your lovely ore mining efforts. The main gimmick is based around cleaning the base up, getting it somewhat functional, and using the drill to extract ore from the comically good ore veins. There are platforms with turrets deployed around them (as well as sandbags) to form a defensible position, but unless you can get into the refinery, it'll be somewhat annoying to actually use. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game It's gimmicky content!! <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: N+S has reported losing contact with one of their rockplanet based mining installations /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Erika Fox <[email protected]>
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <details><summary>Pictures</summary> <p>      </p> </details> Adds a new ruin to the rockplanet pool. The N+S Mining Base is a small mining installation that had been built to extract minerals - and then was promptly raided by the Ramzi Clique (ramzi guys are somewhat waiting on shiptest-ss13#3462. I consider them placeholder right now). The ruin contains a small amount of weaponry, some fluff, and a refinery for your lovely ore mining efforts. The main gimmick is based around cleaning the base up, getting it somewhat functional, and using the drill to extract ore from the comically good ore veins. There are platforms with turrets deployed around them (as well as sandbags) to form a defensible position, but unless you can get into the refinery, it'll be somewhat annoying to actually use. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game It's gimmicky content!! <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: N+S has reported losing contact with one of their rockplanet based mining installations /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Erika Fox <[email protected]>
…to dynamic-human-icons
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: FalloutFalcon <[email protected]>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: FalloutFalcon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
You can now generate simple mob icons via corpse spawners and its cached so its not terribly expensive
port of tgstation/tgstation#72517
and to fix some unit tests ports (which will also minorly improve init times i suspect) that changes how overlays render.
tgstation/tgstation#69696
tgstation/tgstation#73965
tgstation/tgstation#71706
currently only applied to frontiersmen but its very simple to do it for any of them
Why It's Good For The Game
No more ancient simple mob sprites once everything is moved over
Changelog
🆑 FalloutFalcon, Fikou, a hood by Viro
refactor: humanoid mobs automatically generate their sprites, they no longer will be outdated
/:cl: