Add kind installation directory to the PATH #1717
Conversation
Signed-off-by: thasnim-fluxone <[email protected]>
openshift-ci
bot
added
the
release-note
pull-request-size
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind bug |
|
/release-note-none |
|
@thasnim-fluxone: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
/hold
@thasnim-fluxone thank you for your contribution.
Though, I am not sure about it. Having GOPATH/bin in PATH is somehow a normal setup when working with Go as otherwise nothing that is installed through go install will be available. We have other install scripts in the hack directory that - if you want to use the tool afterwards - also rely on this.
Looking for a second opinion @HeavyWombat.
| @@ -13,11 +13,13 @@ set -eu | |||
| DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" &> /dev/null && pwd)" | |||
|
|
|||
| # kind version | |||
| KIND_VERSION="${KIND_VERSION:-v0.22.0}" | |||
| KIND_VERSION="${KIND_VERSION:-v0.24.0}" | |||
There was a problem hiding this comment.
I would not do this without further changes. While it in most cases works, KinD is recommending to use Kubernetes KinD node images that were built for a specific KinD version (see their release notes: https://github.com/kubernetes-sigs/kind/releases/tag/v0.24.0). That means we would have to adjust the used images at other places as well.
Though, bumping Kubernetes dependencies is on our list anyway in preparation of the next Shipwright release.
There was a problem hiding this comment.
Thanks for your attention @SaschaSchwarze0 , I found the script in try it section of the README, as part of setting up the shipwright I run the install-kind.sh script and found it failed without successfully installing the Kind clusters. Hence I created the issue and a PR against it. I agree with your point. I can close this issue and the PR now.
openshift-ci
bot
added
the
do-not-merge/hold
Changes
Updated
hack/install-kind.shscript to fix 'kind: command not found' error.Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes