Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kind installation directory to the PATH #1717

Closed
wants to merge 1 commit into from
Closed

Add kind installation directory to the PATH #1717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hack/install-kind.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ set -eu
DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" &> /dev/null && pwd)"

# kind version
KIND_VERSION="${KIND_VERSION:-v0.22.0}"
KIND_VERSION="${KIND_VERSION:-v0.24.0}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not do this without further changes. While it in most cases works, KinD is recommending to use Kubernetes KinD node images that were built for a specific KinD version (see their release notes: https://github.com/kubernetes-sigs/kind/releases/tag/v0.24.0). That means we would have to adjust the used images at other places as well.

Though, bumping Kubernetes dependencies is on our list anyway in preparation of the next Shipwright release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your attention @SaschaSchwarze0 , I found the script in try it section of the README, as part of setting up the shipwright I run the install-kind.sh script and found it failed without successfully installing the Kind clusters. Hence I created the issue and a PR against it. I agree with your point. I can close this issue and the PR now.


if ! hash kind > /dev/null 2>&1 ; then
echo "# Installing KinD..."
go install "sigs.k8s.io/kind@${KIND_VERSION}"
readonly PATH_TO_KIND="$(go env GOPATH)/bin"
export PATH="$PATH:$PATH_TO_KIND"
fi

# print kind version
Expand Down