-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Go struct field names with YAML/JSON field names #687
Conversation
eeeec4d
to
40f225a
Compare
Signed-off-by: Jason Hall <[email protected]>
@imjasonh can we enhance the Release Notes to include something like:
I think this will affect some internal tooling we have, build-load and shipwright cli, therefore the ask. |
Updated the release notes to reflect that code will need to be updated, but existing client versions should still work in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
GitSource
type is renamed toSource
and moved tosource.go
StrategyRef
type is renamed toStrategy
StrategyRef
field is renamed toStrategy
BuilderImage
field is renamed toBuilder
ImageURL
field is renamed toImage
SecretRef
fields in various places are renamed toCredentials
This is not intended to be a breaking API change for YAML/JSON users (incl objects stored in etcd). This will require updates to clients using generated Go clients to interact with the API, but these changes should be minimal
#516
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes