Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHIP-0023: Add SHIP for BuildRun Status Results #13

Merged
merged 3 commits into from
Aug 31, 2021
Merged

SHIP-0023: Add SHIP for BuildRun Status Results #13

merged 3 commits into from
Aug 31, 2021

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Jun 29, 2021 •
edited
Loading

This SHIP provides a proposal on how to surface Tekton Task Results into the BuildRun Status subresource.

It proposes three types of new fields under the .status subresource, these being:

  • .status.results
  • .status.sources
  • .status.output

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2021
@openshift-ci openshift-ci bot requested review from adambkaplan and sbose78 June 29, 2021 21:01
@qu1queee qu1queee force-pushed the qu1queee/shp0005 branch 8 times, most recently from 40584e3 to 7fc8db6 Compare July 8, 2021 16:14
@qu1queee qu1queee changed the title WIP: Add SHIP for BuildRun Status Results Add SHIP for BuildRun Status Results Jul 8, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2021
@qu1queee
Copy link
Contributor Author

qu1queee commented Jul 8, 2021

@imjasonh @SaschaSchwarze0 this one is ready for review, fyi

@qu1queee qu1queee force-pushed the qu1queee/shp0005 branch 3 times, most recently from 745a240 to cf156cf Compare July 9, 2021 07:00
@qu1queee qu1queee added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2021
@qu1queee qu1queee force-pushed the qu1queee/shp0005 branch from cf156cf to 71c88a1 Compare July 9, 2021 14:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2021
@qu1queee qu1queee changed the title Add SHIP for BuildRun Status Results SHIP-0006: Add SHIP for BuildRun Status Results Jul 9, 2021
@qu1queee qu1queee force-pushed the qu1queee/shp0005 branch from 71c88a1 to f88d5ef Compare July 9, 2021 14:56
SaschaSchwarze0
SaschaSchwarze0 requested changes Jul 12, 2021
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

ships/0006-surface-results-in-buildruns.md Outdated Show resolved Hide resolved
ships/0006-surface-results-in-buildruns.md Outdated Show resolved Hide resolved
ships/0006-surface-results-in-buildruns.md Outdated Show resolved Hide resolved
ships/0006-surface-results-in-buildruns.md Outdated Show resolved Hide resolved
ships/0006-surface-results-in-buildruns.md Outdated Show resolved Hide resolved
@qu1queee qu1queee mentioned this pull request Jul 14, 2021
Closed
4 tasks
@imjasonh imjasonh mentioned this pull request Jul 15, 2021
Closed
@adambkaplan
Copy link
Member

@qu1queee I merged your PR that brought in the old enhancement proposals. Please update the title and numbering to SHIP-0022 so we don't have collisions. Thanks!

@qu1queee
Copy link
Contributor Author

qu1queee commented Aug 1, 2021

I´m closing this one as I cannot provide updates here for the next upcoming weeks. @SaschaSchwarze0 you might wanna re-open with a cherry-pick and changes on top. @HeavyWombat fyi.

@qu1queee qu1queee closed this Aug 1, 2021
@qu1queee qu1queee mentioned this pull request Aug 1, 2021
Closed
4 tasks
@qu1queee qu1queee changed the title SHIP-0006: Add SHIP for BuildRun Status Results SHIP-0023: Add SHIP for BuildRun Status Results Aug 26, 2021
@qu1queee qu1queee reopened this Aug 26, 2021
qu1queee and others added 3 commits August 26, 2021 20:50
@qu1queee
Add SHIP for BuildRun Status Results
3eb7d14 
This SHIP provides a proposal on how to surface Tekton Task Results
into the BuildRun Status subresource.
@qu1queee @SaschaSchwarze0
Apply suggestions from code review
48c6848 
Co-authored-by: Sascha Schwarze <[email protected]>
@qu1queee
rename file to match ships ids
20653f2
SaschaSchwarze0
SaschaSchwarze0 approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things. I cannot (yet) approve in this repo. Proposed it here.

ships/0023-surface-results-in-buildruns.md
}

type Output struct {
DigestOutputResult string `json:"digest,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To conform with our rule that the Go field should be called just like the JSON property.

Suggested change
DigestOutputResult string `json:"digest,omitempty"`
Digest string `json:"digest,omitempty"`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that we should adhere to this in the implementation, I don't think we should block merge of the proposal.

ships/0023-surface-results-in-buildruns.md

type GitSourceResult struct{
CommitSha string `json:"commit-sha,omitempty"`
CommitAuthor string `json:"commit-author,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CommitAuthor string `json:"commit-author,omitempty"`
CommitAuthor string `json:"commit-author,omitempty"` // Not existing today, but outlining how it would look with multiple results

ships/0023-surface-results-in-buildruns.md
}

type HttpSourceResult struct{
Size int `json:"size"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Size int `json:"size"`
Size int `json:"size"` // Not existing today, but outlining how it could look for HTTP

adambkaplan
adambkaplan approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

ships/0023-surface-results-in-buildruns.md
}

type Output struct {
DigestOutputResult string `json:"digest,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that we should adhere to this in the implementation, I don't think we should block merge of the proposal.

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
SaschaSchwarze0
SaschaSchwarze0 approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2021
@openshift-merge-robot openshift-merge-robot merged commit eb77919 into shipwright-io:main Aug 31, 2021
@qu1queee qu1queee deleted the qu1queee/shp0005 branch August 31, 2021 08:33
This was referenced Sep 20, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@adambkaplan adambkaplan adambkaplan approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@adambkaplan adambkaplan

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qu1queee @adambkaplan @SaschaSchwarze0 @openshift-merge-robot