Added changes to handle default slasher broadcast.

[Gua00va]

Issue Addressed

This PR addresses issue #4350

Proposed Changes

This change will enable slasher broadcast by default.

Additional Info

This change will enable slasher broadcast in the following cases:
No flag is passed,
--slasher-broadcast is passed and,
--slasher-broadcast=true is passed.

Only when an explicit false value is passed the slasher does not broadcast.(--slasher-broadcast=false).

TODO

• Modify CLI parsing logic
• Write test

[CLAassistant]

All committers have signed the CLA.

[Gua00va]

@michaelsproul why is this local-testnet check not passing and how do I fix it?

[michaelsproul]

@Gua00va I think it's just a spurious failure. Exit code 132 means illegal instruction: #3089

[Gua00va]

Everything should work now I think!!

[Gua00va]

What is going wrong with the tests here? Can't understand. @michaelsproul

[michaelsproul]

Looks like the release tests are failing because we have a default value for slasher-broadcast, but slasher-broadcast has a .require() on slasher. So it errors. We might need to remove the .require().

Try running the tests locally with cargo test --release -p lighthouse. Those tests are the same ones we should add to as well:

lighthouse/lighthouse/tests/beacon_node.rs

Lines 1884 to 1897 in c547a11

	#[test]
	fn slasher_broadcast_flag() {
	CommandLineTest::new()
	.flag("slasher", None)
	.flag("slasher-broadcast", None)
	.run_with_zero_port()
	.with_config(|config| {
	let slasher_config = config
	.slasher
	.as_ref()
	.expect("Unable to parse Slasher config");
	assert!(slasher_config.broadcast);
	});
	}

[Gua00va]

Looks like the release tests are failing because we have a default value for slasher-broadcast, but slasher-broadcast has a .require() on slasher. So it errors. We might need to remove the .require().

Try running the tests locally with cargo test --release -p lighthouse. Those tests are the same ones we should add to as well:

lighthouse/lighthouse/tests/beacon_node.rs

Lines 1884 to 1897 in c547a11

	#[test]
	fn slasher_broadcast_flag() {
	CommandLineTest::new()
	.flag("slasher", None)
	.flag("slasher-broadcast", None)
	.run_with_zero_port()
	.with_config(|config| {
	let slasher_config = config
	.slasher
	.as_ref()
	.expect("Unable to parse Slasher config");
	assert!(slasher_config.broadcast);
	});
	}

I am unable to run these tests because of mdbx compile error.

[michaelsproul]

@Gua00va Ah, can you try rebasing on my branch? #4360

We're hopefully turning off MDBX by default.

[Gua00va]

@Gua00va Ah, can you try rebasing on my branch? #4360

We're hopefully turning off MDBX by default.

Which branch should I rebase on exactly??

[michaelsproul]

@Gua00va the lmdb-default branch from my fork (michaelsproul/lighthouse).