chore: avoid generating protobuf(proto-google-common-protos) protobufs every time #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s every time protobuf(...) causes protoc to generate code for the listed proto files compileProtoPath adds the listed artifacts on the "include path", so we can reference third-party definitions and generate code for our proto files only. Note: com.google.protobuf searches both compileProtoPath and implementation dependencies for .proto files. io.grpc:grpc-protobuf already depends on proto-google-common-protos, so the build would work even without explicit dependency. However, we import google/api protos, so it would be nice to explicitly mention the used dependencies even though they are present as transitive. Signed-off-by: Vladimir Sitnikov <[email protected]>
|
I guess the reason for the failure is that |
|
gonna close this for now -- I was informed of this issue that might the be underlying problem: protocolbuffers/protobuf#17247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protobuf(...)causes protoc to generate code for the listed proto filescompileProtoPathadds the listed artifacts on the "include path", so we can reference third-party definitions and generate code for our proto files only.Note:
com.google.protobufsearches bothcompileProtoPathand implementation dependencies for .proto files.io.grpc:grpc-protobufalready depends onproto-google-common-protos, so the build would work even without explicit dependency. However, we importgoogle/apiprotos, so it would be nice to explicitly mention the used dependencies even though they are present as transitive.