Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX HTMLEditorField::setRows minimal height #1588

Merged

Conversation

sabina-talipova
Copy link
Contributor

Description

Two additional methods will be passed on tinymce.init event. They will help to adjust input field part of TyniMCE editor. Methods will set calculated height on init and reset height value on editor resize event.

Parent issue

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally works good, js could use a little tidy up

client/src/legacy/HtmlEditorField.js Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/2.1/fix-setRows-height branch from 7185c77 to 9b24e38 Compare January 10, 2024 21:20
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works good

@emteknetnz emteknetnz merged commit bc92e1f into silverstripe:2.1 Jan 11, 2024
12 checks passed
@emteknetnz emteknetnz deleted the pulls/2.1/fix-setRows-height branch January 11, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants