FIX ModelAdmin toast elements #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/1.13/toast-msg-gridfield
branch
from
741dcce to
481c291
Compare
|
Please also add some behat tests (probably just add a "and I should see" to some existing test scenarios) |
sabina-talipova
force-pushed
the
pulls/1.13/toast-msg-gridfield
branch
4 times, most recently
from
8a0eafd to
bcb347e
Compare
|
Updated. Failed tests require PRs: |
sabina-talipova
force-pushed
the
pulls/1.13/toast-msg-gridfield
branch
12 times, most recently
from
ed3c319 to
f59b8ac
Compare
GuySartorelli
requested changes
Nov 7, 2023
sabina-talipova
force-pushed
the
pulls/1.13/toast-msg-gridfield
branch
2 times, most recently
from
90d46b2 to
8858469
Compare
sabina-talipova
commented
Nov 7, 2023
sabina-talipova
force-pushed
the
pulls/1.13/toast-msg-gridfield
branch
2 times, most recently
from
9b682c3 to
dc40a1b
Compare
sabina-talipova
force-pushed
the
pulls/1.13/toast-msg-gridfield
branch
from
dc40a1b to
4180d54
Compare
sabina-talipova
force-pushed
the
pulls/1.13/toast-msg-gridfield
branch
3 times, most recently
from
6ba364b to
9655014
Compare
sabina-talipova
commented
Nov 9, 2023
tests/behat/features/profile.feature
Outdated
| @@ -48,16 +48,16 @@ Feature: Manage my own settings | |||
| And I fill in "New Password" with "a" | |||
| And I fill in "Confirm Password" with "a" | |||
| And I press the "Save" button | |||
| Then I should see "Password is too short" | |||
| Then I should see "Please increase password strength by adding some of the following characters: uppercase, digits, punctuation" | |||
There was a problem hiding this comment.
Test fails since we don't have any settings for min_test_score.
See: https://github.com/silverstripe/silverstripe-framework/blob/8680b6bfb93235547bfac29fcbd9edc8b13c7ab9/_config/passwords.yml#L10-L13
If we have settings then we show the last added message.
sabina-talipova
force-pushed
the
pulls/1.13/toast-msg-gridfield
branch
2 times, most recently
from
fbbe491 to
58252d4
Compare
|
JS CI is failing - might need to be rerun or you might need to rebuild the dist files. |
sabina-talipova
force-pushed
the
pulls/1.13/toast-msg-gridfield
branch
2 times, most recently
from
31d3df7 to
34ef234
Compare
sabina-talipova
force-pushed
the
pulls/1.13/toast-msg-gridfield
branch
from
34ef234 to
53afb90
Compare
GuySartorelli
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue