FIX ModelAdmin toast elements #11037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed tests are unrelated to this PR. This PR should fix #11038 |
GuySartorelli
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Missing toasts for:
- validation errors
- archiving
- published (currently says "saved")
- any actions from the gridfield itself (
...on a row)
The message should also reflect the messages in the pages admin. e.g. when I save a page, it says "Saved 'New Page' successfully."
sabina-talipova
force-pushed
the
pulls/4.13/toast-msg-gridfield
branch
5 times, most recently
from
17ae52e to
673893b
Compare
|
Updated. Required silverstripe/silverstripe-versioned#424 |
GuySartorelli
requested changes
Nov 2, 2023
There was a problem hiding this comment.
Still needs:
- Toasts on validation errors aren't happening
- Toasts aren't happening for any actions from the gridfield itself (
...on a row) - Quotation marks around the name of the item (instead of
Saved Company Some comany name successfullyit should beSaved Company 'Some comany name' successfully.(to match the pages admin)
sabina-talipova
force-pushed
the
pulls/4.13/toast-msg-gridfield
branch
from
673893b to
5416aff
Compare
|
I still don't get any toast when using the options in the |
GuySartorelli
requested changes
Nov 7, 2023
sabina-talipova
force-pushed
the
pulls/4.13/toast-msg-gridfield
branch
from
5416aff to
e5a147e
Compare
This is a part of |
sabina-talipova
force-pushed
the
pulls/4.13/toast-msg-gridfield
branch
from
e5a147e to
d883719
Compare
|
The toasts for validation messages has broken again. |
GuySartorelli
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue