Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Confirm user wishes to delete link #188

Merged
merged 1 commit into from
Jan 24, 2024
Merged

ENH Confirm user wishes to delete link #188

merged 1 commit into from
Jan 24, 2024

Conversation

emteknetnz
Copy link
Member

Issue #175

@emteknetnz emteknetnz mentioned this pull request Jan 24, 2024
Closed
GuySartorelli
GuySartorelli approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works perfectly.

@GuySartorelli
Copy link
Member

Needs to be rebased please

@emteknetnz emteknetnz force-pushed the pulls/4/confirm-delete branch from 5eb19d7 to e6f7705 Compare January 24, 2024 01:50
@emteknetnz
Copy link
Member Author

Done

@GuySartorelli GuySartorelli merged commit 3f24179 into silverstripe:4 Jan 24, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/confirm-delete branch January 24, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli