GraphQL 4 Compatability #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclecheese
force-pushed
the
pulls/1/schemageddon
branch
2 times, most recently
from
e0cb01b to
be90021
Compare
|
Can you leave all the old stuff and manage to keep compatibility with GraphQL <4. As it stands, all these removals of classes cannot happen without a major release. |
|
Yup, fair point. I was just thinking that those classes rely on ancestors that won't exist anymore, but we can put |
18 tasks
sminnee
reviewed
Aug 16, 2020
composer.json
Outdated
| @@ -28,9 +28,6 @@ | |||
| "silverstripe/admin": "^1", | |||
| "squizlabs/php_codesniffer": "^3" | |||
| }, | |||
| "conflict": { | |||
There was a problem hiding this comment.
Would it be better to say "conflict: silverstripe/graphql >= 5"? Or maybe >= 5 || <3?
15 tasks
unclecheese
force-pushed
the
pulls/1/schemageddon
branch
from
7e3ebfb to
d1a75b4
Compare
added 12 commits
October 20, 2020 10:45
unclecheese
force-pushed
the
pulls/1/schemageddon
branch
from
68736db to
46aa27d
Compare
unclecheese
force-pushed
the
pulls/1/schemageddon
branch
6 times, most recently
from
e08d67c to
fc338de
Compare
unclecheese
force-pushed
the
pulls/1/schemageddon
branch
6 times, most recently
from
32dad8a to
54d0b0e
Compare
unclecheese
force-pushed
the
pulls/1/schemageddon
branch
from
54d0b0e to
61b8e99
Compare
|
Moved to: #308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.