-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile and CI workflows building Docker images on new releases #12
Conversation
I think there should also be a way to set the concurrency and memory limit via external environment variables. |
This doesn't actually remove Python 2 support from the code though.
I've cleaned up the readme file and Additionally, I've added workflows to run the tests on every push, and to publish a Docker image on every new release (we need to decide where to publish said images, though). |
I have updated the build action to push images to Docker Hub. For it to work, the Docker Hub username and password/access token need to be configured as secrets in the repository settings:
Docker's documentation recommends creating an access token for the purpose of pushing images. Additionally, a |
As mentioned in sio2project/oioioi#126, in this PR I'm adding a
Dockerfile
that builds a working Docker image for sioworkers. It might also be worth adding a GitHub Actions workflow that builds a new image after creating a new release, but I would prefer to consult with project maintainers on where the images should be published beforehand.I've also noticed that there's an old Docker setup in
docker/
, however since it seems fairly old, I wasn't sure if it's being in active use, and if there's a point in updating it.