Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventDispatcher setter + trace in Post/Fail event #101

Merged
merged 5 commits into from
Sep 20, 2022
Merged

EventDispatcher setter + trace in Post/Fail event #101

merged 5 commits into from
Sep 20, 2022

Conversation

jan-stanek
Copy link
Member

@jan-stanek jan-stanek commented Apr 10, 2022 •
edited
Loading

Používá se ve SkautisNette pro tracy panel - skaut/SkautisNette#33

@jan-stanek jan-stanek marked this pull request as draft April 10, 2022 12:53
@coveralls
Copy link

coveralls commented Apr 10, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2144680698

  • 10 of 17 (58.82%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.08%) to 82.353%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Wsdl/Event/RequestFailEvent.php 3 4 75.0%
src/Wsdl/Event/RequestPostEvent.php 3 4 75.0%
src/Wsdl/WebService.php 4 5 80.0%
src/Wsdl/WsdlManager.php 0 1 0.0%
src/Wsdl/WebServiceFactory.php 0 3 0.0%
Totals Coverage Status
Change from base Build 2143512575: -1.08%
Covered Lines: 280
Relevant Lines: 340
💛 - Coveralls

@jan-stanek jan-stanek marked this pull request as ready for review April 10, 2022 16:50
@jan-stanek jan-stanek mentioned this pull request Apr 10, 2022
Merged
@sinacek sinacek requested review from JindrichPilar and fmasa April 10, 2022 17:06
@jan-stanek jan-stanek changed the title EventDispatcher setter added EventDispatcher setter + trace in Post/Fail event Apr 10, 2022
@jan-stanek
Copy link
Member Author

Můžeme mergnout a vydat verzi 3.0.0-alpha.4? Závisí na tom skaut/SkautisNette#33

@jan-stanek jan-stanek mentioned this pull request Sep 16, 2022
Merged
2 tasks
@jan-stanek jan-stanek merged commit 15deee9 into skaut:3.x Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JindrichPilar JindrichPilar Awaiting requested review from JindrichPilar

@fmasa fmasa Awaiting requested review from fmasa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-stanek @coveralls