Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"followers" and "inbox" keys are not in JSON-LD context #87

Closed
acka47 opened this issue Jun 18, 2020 · 5 comments · Fixed by #88
Closed

"followers" and "inbox" keys are not in JSON-LD context #87

acka47 opened this issue Jun 18, 2020 · 5 comments · Fixed by #88
Assignees
Labels
bug Something isn't working

Comments

@acka47
Copy link
Member

acka47 commented Jun 18, 2020

See e.g. https://skohub.io/hbz/vocabs-edu/heads/master/w3id.org/class/esc/n0322.json:

{
  "id":"https://w3id.org/class/esc/n0322",
  "type":"Concept",
  "followers":"https://skohub.io/followers?subject=hbz%2Fvocabs-edu%2Fheads%2Fmaster%2Fw3id.org%2Fclass%2Fesc%2Fn0322",
  "inbox":"https://skohub.io/inbox?actor=hbz%2Fvocabs-edu%2Fheads%2Fmaster%2Fw3id.org%2Fclass%2Fesc%2Fn0322",
  "prefLabel":{
    "en":"Library, information and archival studies"
  },
  "notation":[
    "0322"
  ],
  "broader":{
    "id":"https://w3id.org/class/esc/n032",
    "prefLabel":{
      "en":"Journalism and information"
    }
  },
  "inScheme":{
    "id":"https://w3id.org/class/esc/scheme",
    "title":{
      "en":"Educational Subjects Classification"
    }
  },
  "@context":{
    "id":"@id",
    "type":"@type",
    "@vocab":"http://www.w3.org/2004/02/skos/core#",
    "xsd":"http://www.w3.org/2001/XMLSchema#",
    "dct":"http://purl.org/dc/terms/",
    "schema":"http://schema.org/",
    "vann":"http://purl.org/vocab/vann/",
    "title":{
      "@id":"dct:title",
      "@container":"@language"
    },
    "description":{
      "@id":"dct:description",
      "@container":"@language"
    },
    "issued":{
      "@id":"dct:issued",
      "@type":"xsd:date"
    },
    "created":{
      "@id":"dct:created",
      "@type":"xsd:date"
    },
    "modified":{
      "@id":"dct:modified",
      "@type":"xsd:date"
    },
    "creator":"dct:creator",
    "publisher":"dct:publisher",
    "preferredNamespacePrefix":"vann:preferredNamespacePrefix",
    "preferredNamespaceUri":"vann:preferredNamespaceUri",
    "isBasedOn":"schema:isBasedOn",
    "source":"dct:source",
    "prefLabel":{
      "@container":"@language"
    },
    "definition":{
      "@container":"@language"
    },
    "scopeNote":{
      "@container":"@language"
    },
    "note":{
      "@container":"@language"
    },
    "notation":{
      "@container":"@set"
    },
    "narrower":{
      "@container":"@set"
    },
    "narrowerTransitive":{
      "@container":"@set"
    },
    "broaderTransitive":{
      "@container":"@set"
    }
  }
}
@acka47 acka47 added the bug Something isn't working label Jun 18, 2020
@acka47 acka47 self-assigned this Jun 18, 2020
acka47 added a commit that referenced this issue Jun 18, 2020
@acka47
Copy link
Member Author

acka47 commented Jun 19, 2020

Taking a look at https://skohub.io/hbz/vocabs-edu/heads/master/w3id.org/class/esc/n0322.jsonas, I notice that the same followers and inbox statements can already be found there. Thus, the question: Do we need this redundancy or could the statements be removed from the JSON/SKOS representation?

@dr0i
Copy link
Member

dr0i commented Jun 23, 2020

The last question remains to be unanswered, so I reopened this issue.
Also, the embedded context is not automatically updated for e.g. https://skohub.io/hbz/vocabs-edu/heads/master/w3id.org/class/esc/n0322.json . Thus, if I understand correctly, all vocabs must be rebuild. How triggers this?

@dr0i dr0i reopened this Jun 23, 2020
@literarymachine
Copy link
Contributor

Also, the embedded context is not automatically updated for e.g. https://skohub.io/hbz/vocabs-edu/heads/master/w3id.org/class/esc/n0322.json . Thus, if I understand correctly, all vocabs must be rebuild.

Maybe we should consider referencing a remote context instead of embedding it? That way it could be updated without the need to rebuild vocab data.

@acka47
Copy link
Member Author

acka47 commented Jun 23, 2020

Maybe we should consider referencing a remote context instead of embedding it? That way it could be updated without the need to rebuild vocab data.

Yes, we should definitely do this.

@acka47
Copy link
Member Author

acka47 commented Jun 23, 2020

I opened a new issue for the remote context, see #89. I will now close this issue.

@acka47 acka47 closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants