-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Ronin configs #1517
add Ronin configs #1517
Conversation
@@ -0,0 +1,10 @@ | |||
ChainID = "2021" | |||
FinalityTagEnabled = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need the depth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the FinalityDepth here needs further discussion for an appropriate value, as Ronin has a constant 2 block finality and very fast block production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we decided to use a minimum buffer for chains with short & constant finality, please start a thread. I'd suggest to set it at 10 ( if thats the fallback value, you can leave it empty), cc @prashantkumar1982
ccip/config/evm/Ronin_Saigon.toml
Outdated
ChainID = "2021" | ||
FinalityTagEnabled = true | ||
LinkContractAddress = "0x5bB50A6888ee6a67E22afFDFD9513be7740F1c15" | ||
LogPollInterval = "6s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ronin produces a block every 3s, would it be more appropriate to set this also to 3s or is 6s suitable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 3-4s or closer is better to get the notice the events quicker, but not a massive difference, but please do leave comments about the block rate
ccip/config/evm/Ronin_Mainnet.toml
Outdated
FinalityTagEnabled = true | ||
LinkContractAddress = "0x3902228D6A3d2Dc44731fD9d45FeE6a61c722D0b" | ||
LogPollInterval = "6s" | ||
NoNewHeadsThreshold = "10m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a block rate of 3s, this seems a bit higher to declare unhealthy, can we reduce it to 3-5m?
Motivation
Solution