Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Ronin configs #1517

Merged
merged 14 commits into from
Nov 8, 2024
Merged

add Ronin configs #1517

merged 14 commits into from
Nov 8, 2024

Conversation

amaechiokolobi
Copy link
Collaborator

Motivation

Solution

@amaechiokolobi amaechiokolobi requested a review from a team as a code owner November 1, 2024 06:04
docs/CONFIG.md Outdated Show resolved Hide resolved
@@ -0,0 +1,10 @@
ChainID = "2021"
FinalityTagEnabled = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need the depth

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the FinalityDepth here needs further discussion for an appropriate value, as Ronin has a constant 2 block finality and very fast block production.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to use a minimum buffer for chains with short & constant finality, please start a thread. I'd suggest to set it at 10 ( if thats the fallback value, you can leave it empty), cc @prashantkumar1982

ChainID = "2021"
FinalityTagEnabled = true
LinkContractAddress = "0x5bB50A6888ee6a67E22afFDFD9513be7740F1c15"
LogPollInterval = "6s"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave comments

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ronin produces a block every 3s, would it be more appropriate to set this also to 3s or is 6s suitable?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 3-4s or closer is better to get the notice the events quicker, but not a massive difference, but please do leave comments about the block rate

FinalityTagEnabled = true
LinkContractAddress = "0x3902228D6A3d2Dc44731fD9d45FeE6a61c722D0b"
LogPollInterval = "6s"
NoNewHeadsThreshold = "10m"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a block rate of 3s, this seems a bit higher to declare unhealthy, can we reduce it to 3-5m?

@amaechiokolobi amaechiokolobi merged commit ab7fa09 into ccip-develop Nov 8, 2024
155 of 157 checks passed
@amaechiokolobi amaechiokolobi deleted the ronin-config branch November 8, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants