Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Ronin configs #1517

Merged
merged 14 commits into from
Nov 8, 2024
+250 −0
Merged

add Ronin configs #1517

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f27d661
added Ronin configs
amaechiokolobi Nov 1, 2024
a0bdfbd
Merge branch 'ccip-develop' into ronin-config
amaechiokolobi Nov 1, 2024
b7c8be4
updated PriceMax
amaechiokolobi Nov 4, 2024
7b7416b
Merge branch 'ronin-config' of github.com:smartcontractkit/ccip into …
amaechiokolobi Nov 4, 2024
4a32331
Merge branch 'ccip-develop' into ronin-config
amaechiokolobi Nov 4, 2024
07acdd9
updated PriceMax
amaechiokolobi Nov 4, 2024
e7aa469
Merge branch 'ronin-config' of github.com:smartcontractkit/ccip into …
amaechiokolobi Nov 4, 2024
691c87d
update PriceMax
amaechiokolobi Nov 4, 2024
7421db7
changed mode to FeeHistory
amaechiokolobi Nov 4, 2024
dda63ce
removed PriceDefault & PriceMin
amaechiokolobi Nov 5, 2024
8478f33
added comments
amaechiokolobi Nov 5, 2024
3f53638
update config
amaechiokolobi Nov 8, 2024
ac60a34
Merge branch 'ccip-develop' into ronin-config
amaechiokolobi Nov 8, 2024
c2f115f
Merge branch 'ccip-develop' into ronin-config
amaechiokolobi Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ccip/config/evm/Ronin_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ChainID = "2020"
FinalityTagEnabled = true
LinkContractAddress = "0x3902228D6A3d2Dc44731fD9d45FeE6a61c722D0b"
LogPollInterval = "6s"
NoNewHeadsThreshold = "10m"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a block rate of 3s, this seems a bit higher to declare unhealthy, can we reduce it to 3-5m?


[GasEstimator]
# Ronin uses default gas price of 20 gwei https://docs.skymavis.com/mavis/mpc/guides/estimate-gas#overview
Mode = 'FeeHistory'
PriceMax = "1000 gwei"
10 changes: 10 additions & 0 deletions ccip/config/evm/Ronin_Saigon.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ChainID = "2021"
FinalityTagEnabled = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need the depth

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the FinalityDepth here needs further discussion for an appropriate value, as Ronin has a constant 2 block finality and very fast block production.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to use a minimum buffer for chains with short & constant finality, please start a thread. I'd suggest to set it at 10 ( if thats the fallback value, you can leave it empty), cc @prashantkumar1982

LinkContractAddress = "0x5bB50A6888ee6a67E22afFDFD9513be7740F1c15"
LogPollInterval = "6s"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave comments

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ronin produces a block every 3s, would it be more appropriate to set this also to 3s or is 6s suitable?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 3-4s or closer is better to get the notice the events quicker, but not a massive difference, but please do leave comments about the block rate

NoNewHeadsThreshold = "10m"

[GasEstimator]
# Ronin uses default gas price of 20 gwei https://docs.skymavis.com/mavis/mpc/guides/estimate-gas#overview
Mode = 'FeeHistory'
PriceMax = "1000 gwei"
10 changes: 10 additions & 0 deletions core/chains/evm/config/toml/defaults/Ronin_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ChainID = "2020"
FinalityTagEnabled = true
LinkContractAddress = "0x3902228D6A3d2Dc44731fD9d45FeE6a61c722D0b"
LogPollInterval = "6s"
NoNewHeadsThreshold = "10m"

[GasEstimator]
# Ronin uses default gas price of 20 gwei https://docs.skymavis.com/mavis/mpc/guides/estimate-gas#overview
Mode = 'FeeHistory'
PriceMax = "1000 gwei"
10 changes: 10 additions & 0 deletions core/chains/evm/config/toml/defaults/Ronin_Saigon.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ChainID = "2021"
FinalityTagEnabled = true
LinkContractAddress = "0x5bB50A6888ee6a67E22afFDFD9513be7740F1c15"
LogPollInterval = "6s"
NoNewHeadsThreshold = "10m"

[GasEstimator]
# Ronin uses default gas price of 20 gwei https://docs.skymavis.com/mavis/mpc/guides/estimate-gas#overview
Mode = 'FeeHistory'
PriceMax = "1000 gwei"
206 changes: 206 additions & 0 deletions docs/CONFIG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5668,6 +5668,212 @@ GasLimitDefault = 400000

</p></details>

<details><summary>Ronin Mainnet (2020)</summary><p>

```toml
AutoCreateKey = true
BlockBackfillDepth = 10
BlockBackfillSkip = false
FinalityDepth = 50
FinalityTagEnabled = true
LinkContractAddress = '0x3902228D6A3d2Dc44731fD9d45FeE6a61c722D0b'
LogBackfillBatchSize = 1000
LogPollInterval = '6s'
LogKeepBlocksDepth = 100000
LogPrunePageSize = 10000
BackupLogPollerBlockDelay = 100
MinIncomingConfirmations = 3
MinContractPayment = '0.00001 link'
NonceAutoSync = true
NoNewHeadsThreshold = '10m0s'
LogBroadcasterEnabled = true
RPCDefaultBatchSize = 250
RPCBlockQueryDelay = 1
FinalizedBlockOffset = 0
NoNewFinalizedHeadsThreshold = '0s'

[Transactions]
ForwardersEnabled = false
MaxInFlight = 16
MaxQueued = 250
ReaperInterval = '1h0m0s'
ReaperThreshold = '168h0m0s'
ResendAfterThreshold = '1m0s'

[Transactions.AutoPurge]
Enabled = false

[BalanceMonitor]
Enabled = true

[GasEstimator]
Mode = 'FeeHistory'
PriceDefault = '20 gwei'
PriceMax = '1 micro'
PriceMin = '1 gwei'
LimitDefault = 8000000
LimitMax = 8000000
LimitMultiplier = '1'
LimitTransfer = 21000
EstimateLimit = false
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 3
EIP1559DynamicFees = false
FeeCapDefault = '100 gwei'
TipCapDefault = '1 wei'
TipCapMin = '1 wei'

[GasEstimator.BlockHistory]
BatchSize = 25
BlockHistorySize = 8
CheckInclusionBlocks = 12
CheckInclusionPercentile = 90
TransactionPercentile = 60

[GasEstimator.FeeHistory]
CacheTimeout = '10s'

[HeadTracker]
HistoryDepth = 100
MaxBufferSize = 3
SamplingInterval = '1s'
MaxAllowedFinalityDepth = 10000
FinalityTagBypass = true

[NodePool]
PollFailureThreshold = 5
PollInterval = '10s'
SelectionMode = 'HighestHead'
SyncThreshold = 5
LeaseDuration = '0s'
NodeIsSyncingEnabled = false
FinalizedBlockPollInterval = '5s'
EnforceRepeatableRead = false
DeathDeclarationDelay = '10s'
NewHeadsPollInterval = '0s'

[OCR]
ContractConfirmations = 4
ContractTransmitterTransmitTimeout = '10s'
DatabaseTimeout = '10s'
DeltaCOverride = '168h0m0s'
DeltaCJitterOverride = '1h0m0s'
ObservationGracePeriod = '1s'

[OCR2]
[OCR2.Automation]
GasLimit = 5400000

[Workflow]
GasLimitDefault = 400000
```

</p></details>

<details><summary>Ronin Saigon (2021)</summary><p>

```toml
AutoCreateKey = true
BlockBackfillDepth = 10
BlockBackfillSkip = false
FinalityDepth = 50
FinalityTagEnabled = true
LinkContractAddress = '0x5bB50A6888ee6a67E22afFDFD9513be7740F1c15'
LogBackfillBatchSize = 1000
LogPollInterval = '6s'
LogKeepBlocksDepth = 100000
LogPrunePageSize = 10000
BackupLogPollerBlockDelay = 100
MinIncomingConfirmations = 3
MinContractPayment = '0.00001 link'
NonceAutoSync = true
NoNewHeadsThreshold = '10m0s'
LogBroadcasterEnabled = true
RPCDefaultBatchSize = 250
RPCBlockQueryDelay = 1
FinalizedBlockOffset = 0
NoNewFinalizedHeadsThreshold = '0s'

[Transactions]
ForwardersEnabled = false
MaxInFlight = 16
MaxQueued = 250
ReaperInterval = '1h0m0s'
ReaperThreshold = '168h0m0s'
ResendAfterThreshold = '1m0s'

[Transactions.AutoPurge]
Enabled = false

[BalanceMonitor]
Enabled = true

[GasEstimator]
Mode = 'FeeHistory'
PriceDefault = '20 gwei'
PriceMax = '1 micro'
PriceMin = '1 gwei'
LimitDefault = 8000000
LimitMax = 8000000
LimitMultiplier = '1'
LimitTransfer = 21000
EstimateLimit = false
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 3
EIP1559DynamicFees = false
FeeCapDefault = '100 gwei'
TipCapDefault = '1 wei'
TipCapMin = '1 wei'

[GasEstimator.BlockHistory]
BatchSize = 25
BlockHistorySize = 8
CheckInclusionBlocks = 12
CheckInclusionPercentile = 90
TransactionPercentile = 60

[GasEstimator.FeeHistory]
CacheTimeout = '10s'

[HeadTracker]
HistoryDepth = 100
MaxBufferSize = 3
SamplingInterval = '1s'
MaxAllowedFinalityDepth = 10000
FinalityTagBypass = true

[NodePool]
PollFailureThreshold = 5
PollInterval = '10s'
SelectionMode = 'HighestHead'
SyncThreshold = 5
LeaseDuration = '0s'
NodeIsSyncingEnabled = false
FinalizedBlockPollInterval = '5s'
EnforceRepeatableRead = false
DeathDeclarationDelay = '10s'
NewHeadsPollInterval = '0s'

[OCR]
ContractConfirmations = 4
ContractTransmitterTransmitTimeout = '10s'
DatabaseTimeout = '10s'
DeltaCOverride = '168h0m0s'
DeltaCJitterOverride = '1h0m0s'
ObservationGracePeriod = '1s'

[OCR2]
[OCR2.Automation]
GasLimit = 5400000

[Workflow]
GasLimitDefault = 400000
```

</p></details>

<details><summary>Kroma Sepolia (2358)</summary><p>

```toml
Expand Down
Loading