CCIP-1716 Adding retention to filters used by LogPoller #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
reviewed
Feb 21, 2024
RensR
reviewed
Feb 21, 2024
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/offramp.go
Outdated
Show resolved
Hide resolved
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
de1794e to
3849a1e
Compare
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
3849a1e to
35bf034
Compare
mateusz-sekara
changed the title
RensR
approved these changes
Feb 21, 2024
makramkd
approved these changes
Feb 21, 2024
mateusz-sekara
changed the title
|
Do not merge before Core 2.10 |
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
2f9cb7b to
2e376af
Compare
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
2e376af to
912ef2f
Compare
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
912ef2f to
896db41
Compare
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
3fb5397 to
7baa4b2
Compare
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
7baa4b2 to
fc8de5f
Compare
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
fc8de5f to
3301dc8
Compare
makramkd
reviewed
Mar 19, 2024
Co-authored-by: Makram <[email protected]>
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
9054b1d to
805eb06
Compare
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
805eb06 to
a48d3ca
Compare
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
a48d3ca to
72d07ac
Compare
mateusz-sekara
force-pushed
the
logpoller-retention-filters
branch
from
72d07ac to
9d9ba13
Compare
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
## Motivation The goal of this PR is to reduce the number of logs and blocks we keep in the database by utilizing a built-in retention mechanism in LogPoller. Requires paging for smooth deployment smartcontractkit/chainlink#12060 ## Solution This PR enables retention for all the LogPoller's filters registered by CCIP. Additionally, to avoid pushing too much pressure during deletion (especially the first run will have a lot of logs to remove) we've updated `LogPrunePageSize` to 10k. Please see the original PR in the chainlink repo to learn more about paging and its impact on the database. `LogPrunePageSize` is altered in the `fallback.toml` to avoid the necessity of setting this value for every chain that CCIP is deployed on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goal of this PR is to reduce the number of logs and blocks we keep in the database by utilizing a built-in retention mechanism in LogPoller.
Requires paging for smooth deployment smartcontractkit/chainlink#12060
Solution
This PR enables retention for all the LogPoller's filters registered by CCIP. Additionally, to avoid pushing too much pressure during deletion (especially the first run will have a lot of logs to remove) we've updated
LogPrunePageSizeto 10k. Please see the original PR in the chainlink repo to learn more about paging and its impact on the database.LogPrunePageSizeis altered in thefallback.tomlto avoid the necessity of setting this value for every chain that CCIP is deployed on.