[BCF-2365] Combine providers #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cedric-cordenier
commented
Sep 1, 2023
•
cedric-cordenier
commented
- Remove NewMercuryProvider, NewMedianProvider, NewFunctionsProvider from the Relayer interface. This is to allow transparent proxying of provider calls from reporting plugin loopps to relayer loopps, without the core node needing to be aware of the types.
- From now on, creating a provider should happen via NewPluginProvider, setting RelayArgs.ProviderType as appropriate.
- LOOPP Relayer implementations can still implement NewMercuryProvider/NewMedianProvider/.... The RelayerServer will check whether the underlying implementation contains these methods and will redirect the call to this more specialized function if that is the case.
- For interoperability with legacy code in the core node which needs to be aware of the product providers, the RelayerClient will instantiate a provider of the right type inside NewPluginProvider, thus allowing calling code to typecast to the right underlying provider type.
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
force-pushed
the
BCF-2365-combine-providers
branch
from
61cdbd9 to
39e4d6f
Compare
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
force-pushed
the
BCF-2365-combine-providers
branch
from
39e4d6f to
ac7a4ac
Compare
- Remove NewMercuryProvider, NewMedianProvider, NewFunctionsProvider from the Relayer interface. This is to allow transparent proxying of provider calls from reporting plugin loopps to relayer loopps, without the core node needing to be aware of the types. - From now on, creating a provider should happen via NewPluginProvider, setting RelayArgs.ProviderType as appropriate. - RelayArgs.ProviderType maps to the OCR2PluginType, which this commit relocates from the core node to here. - LOOPP Relayer implementations can still implement NewMercuryProvider/NewMedianProvider/.... The RelayerServer will check whether the underlying implementation contains these methods and will redirect the call to this more specialized function if that is the case. - For interoperability with legacy code in the core node which needs to be aware of the product providers, the RelayerClient will instantiate a provider of the right type inside NewPluginProvider, thus allowing calling code to typecast to the right underlying provider type.
cedric-cordenier
force-pushed
the
BCF-2365-combine-providers
branch
from
ac7a4ac to
b9ec885
Compare
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
requested review from
jmank88 and
krebernisak
as code owners
|
Corresponding chainlink PR: |
jmank88
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.