pkg/sqlutil: switch TimeoutHook argument to func for dynamic reconfiguration; add TransactDataSource #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
requested review from
samsondav,
krehermann,
patrickhuie19 and
DylanTinianov
jmank88
force-pushed
the
dynamic-timeout-hook
branch
from
051ee9f to
91e05ff
Compare
samsondav
previously approved these changes
Mar 15, 2024
krehermann
previously approved these changes
Mar 15, 2024
jmank88
force-pushed
the
dynamic-timeout-hook
branch
from
91e05ff to
4ce47fb
Compare
jmank88
force-pushed
the
dynamic-timeout-hook
branch
from
4ce47fb to
2dffd98
Compare
jmank88
changed the title
1 task
jmank88
force-pushed
the
dynamic-timeout-hook
branch
from
2dffd98 to
82d244f
Compare
jmank88
force-pushed
the
dynamic-timeout-hook
branch
from
82d244f to
ca50630
Compare
jmank88
force-pushed
the
dynamic-timeout-hook
branch
from
ca50630 to
6f05dc3
Compare
…uration; add TransactDataSource
jmank88
force-pushed
the
dynamic-timeout-hook
branch
from
6f05dc3 to
627eed0
Compare
krehermann
approved these changes
Mar 24, 2024
krehermann
had a problem deploying
to
integration
GitHub Actions
Failure
ettec
pushed a commit
that referenced
this pull request
Mar 28, 2024
…uration; add TransactDataSource (#403) Co-authored-by: krehermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: https://smartcontract-it.atlassian.net/browse/BCF-2978
TimeoutHookfrom a static value to a func for dynamic reconfigurationNamedExecContext&PrepareNamedContexttosqlutil.DataSourceTransactDataSourcefor raw SQL txsSupports: