Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sqlutil instead of pg.QOpts/Q/Queryer #12456

Merged
merged 3 commits into from
Apr 24, 2024
Merged

use sqlutil instead of pg.QOpts/Q/Queryer #12456

merged 3 commits into from
Apr 24, 2024

Conversation

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tx was not actually used.

core/services/job/orm.go Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Mar 20, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88 jmank88 force-pushed the sqlutil-wrapdb-txs branch 2 times, most recently from c78844c to 94c4e8e Compare March 21, 2024 13:05
@jmank88
Copy link
Contributor Author

jmank88 commented Apr 24, 2024

Looks good. Please add a changeset via the pnpm tool and please do not force push over this current state because it makes re-reviewing much more difficult. IMHO the changset should be major and internal. Major in the sense that it changes large portions of the code base in an interesting way

Why do you say major? We are not breaking compatibility, and we are preserving behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants