Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unimplemented ChainReader() method to MedianProvider #379

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

reductionista
Copy link
Contributor

@reductionista reductionista commented Oct 18, 2023

This needs to be added just after we update the interface definition of PlugProvider in chainlink-relay for the ChainReader POC, but just before the associated downstream changes in the Chainlink repo

smartcontractkit/chainlink-common#196

core ref: BCF-2612-ChainReader-EVM-POC

nolag
nolag previously approved these changes Nov 27, 2023
jmank88
jmank88 previously approved these changes Dec 5, 2023
@jmank88 jmank88 requested review from cfal and aalu1418 December 5, 2023 18:10
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

@jmank88 jmank88 merged commit 516a805 into develop Dec 6, 2023
14 of 16 checks passed
@jmank88 jmank88 deleted the BCF-2612-ChainReader branch December 6, 2023 12:04
@jmank88 jmank88 mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants