Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimal ChainReader interface & types #196

Merged
merged 78 commits into from
Dec 5, 2023
Merged

Add minimal ChainReader interface & types #196

merged 78 commits into from
Dec 5, 2023

Conversation

reductionista
Copy link
Contributor

@reductionista reductionista commented Oct 12, 2023 •
edited
Loading

This adds theChainReader() method to the PluginProvider type definition, and ChainReader type definitions in chain_reader.go

This is intended to be merged just before merging these related PR's which depend on it:

  1. Interfaces and skeleton methods for ChainReader EVM POC chainlink#10990
  2. Add unimplemented ChainReader() method to MedianProvider chainlink-cosmos#379
  3. Add unimplemented ChainReader() method to MedianProvider chainlink-solana#552
  4. Add unimplemented ChainReader() method to MedianProvider chainlink-starknet#331

This commit should get reverted immediately after--it comments out the changes here which depend on the above PR's:
cd7d4e4

@reductionista reductionista force-pushed the BCF-2612-ChainReader branch 3 times, most recently from 289aadc to 416f190 Compare October 13, 2023 21:01
@reductionista reductionista mentioned this pull request Oct 18, 2023
Merged
This was referenced Oct 18, 2023
Merged
Merged
Merged
jmank88
jmank88 reviewed Dec 4, 2023
View reviewed changes
pkg/types/provider.go Outdated Show resolved Hide resolved
jmank88
jmank88 previously approved these changes Dec 4, 2023
View reviewed changes
@reductionista @jmank88
Use slices api
57a6e90 
Co-authored-by: Jordan Krage <[email protected]>
jmank88
jmank88 previously approved these changes Dec 5, 2023
View reviewed changes
@reductionista
Use tests.Context(t) instead of context.Background()
0984572 
There was an intermittant race condition showing up, where the grpc client loop
doesn't get shut down when the test exits, so it ends up printing a
debug msg fter the test exits. Hopefully this fixes it?
@reductionista reductionista merged commit dfac15e into main Dec 5, 2023
5 of 8 checks passed
@reductionista reductionista deleted the BCF-2612-ChainReader branch December 5, 2023 03:38
george-dorin added a commit that referenced this pull request Dec 5, 2023
@george-dorin
Revert "Add minimal ChainReader interface & types (#196)"
0fd38d1 
This reverts commit dfac15e
nolag added a commit that referenced this pull request Dec 7, 2023
@nolag @dimriou
@jmank88 @samsondav @dhaidashenko @reductionista @ilija42 @tateexon
merge main to branch since BCF-2612-ChainReader was merged. (#275)
1a40c33 
* Logger extraction (#253)

Co-authored-by: Jordan Krage <[email protected]>

* pkg/services/servicetest: add Run and RunHealthy helpers (#251)

* pkg/services/servicetest: remove debug fmt.Println (#259)

* Bump MaxAllowedBlocks from 5 to 10 (#260)

* pkg/services: add ver & sha params to HealthChecker (#265)

* Utils extraction from chainlink repo (#256)

* Adjust price scaling factor from 1e8 => 1e18 (#266)

* Adjust price scaling factor from 1e8 => 1e18

* Adjust price scaling from 1e8 => 1e18

- Reference: MERC-1771

* Add mathutil (#267)

Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Dmytro Haidashenko <[email protected]>

* pkg/reportingplugins: remove; move mercury to chainlink-data-streams (#240)

* Add minimal ChainReader interface & types (#196)

Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Ryan Tinianov <[email protected]>
Co-authored-by: ilija42 <[email protected]>

* Bump action to get relay renamed to common changes (#272)

* .

---------

Co-authored-by: Dimitris Grigoriou <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Sam <[email protected]>
Co-authored-by: Dmytro Haidashenko <[email protected]>
Co-authored-by: Domino Valdano <[email protected]>
Co-authored-by: ilija42 <[email protected]>
Co-authored-by: Tate <[email protected]>
samsondav pushed a commit that referenced this pull request Jan 11, 2024
@reductionista @jmank88
@nolag @ilija42 @samsondav
Add minimal ChainReader interface & types (#196)
b1b8d22 
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Ryan Tinianov <[email protected]>
Co-authored-by: ilija42 <[email protected]>
ettec pushed a commit that referenced this pull request Mar 28, 2024
@reductionista @jmank88
@nolag @ilija42 @ettec
Add minimal ChainReader interface & types (#196)
324e6c7 
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Ryan Tinianov <[email protected]>
Co-authored-by: ilija42 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 left review comments

@cedric-cordenier cedric-cordenier cedric-cordenier left review comments

@nolag nolag nolag left review comments

@jmank88 jmank88 jmank88 approved these changes

@krebernisak krebernisak Awaiting requested review from krebernisak

@topliceanu topliceanu Awaiting requested review from topliceanu topliceanu is a code owner

@pedrovsg pedrovsg Awaiting requested review from pedrovsg pedrovsg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reductionista @jmank88 @nolag @cedric-cordenier @ilija42