Add Gas Price Data Source #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustbleeds
commented
Jan 23, 2024
augustbleeds
commented
Jan 23, 2024
augustbleeds
commented
Jan 23, 2024
This was referenced Jan 23, 2024
augustbleeds
commented
Jan 23, 2024
augustbleeds
commented
May 15, 2024
go.mod
Outdated
| @@ -4,14 +4,16 @@ go 1.21.3 | |||
|
|
|||
| require ( | |||
| github.com/hashicorp/go-plugin v1.6.0 | |||
| github.com/smartcontractkit/chainlink-common v0.1.7-0.20240327133125-eed636b9a6df | |||
| github.com/smartcontractkit/chainlink-common v0.1.7-0.20240515160501-a375a7ccb29e | |||
There was a problem hiding this comment.
will point to master once smartcontractkit/chainlink-common#509 is merged
augustbleeds
commented
May 15, 2024
| @@ -33,6 +34,11 @@ func aggregate(observations []median.ParsedAttributedObservation) *aggregatedAtt | |||
| }) | |||
| aggregated.JuelsPerFeeCoin = observations[n/2].JuelsPerFeeCoin | |||
|
|
|||
| slices.SortFunc(observations, func(a, b median.ParsedAttributedObservation) int { | |||
There was a problem hiding this comment.
extracts the GasPriceSubunits to the aggregated observation. If it uses the default codec or codecs that do not know about this field, then field is ignored (see https://chainlink-core.slack.com/archives/C03EZMT3XPX/p1715627908908079?thread_ts=1711719895.085089&cid=C03EZMT3XPX).
If it's on Starknet, the Starknet codec will utilize it
jmank88
reviewed
May 16, 2024
jmank88
previously approved these changes
May 17, 2024
Thanks, will update now that chainlink-common has been merged here smartcontractkit/chainlink-common#509 |
jmank88
approved these changes
May 22, 2024
augustbleeds
added a commit
that referenced
this pull request
Jun 14, 2024
* adjust for nil case * add gas price to test cases * update libocr and chainlink-common * update libocr and chainlink-common * update common again * remove replace * update deps * update NewMedianFactory * update variable naming * simplify logic * simplify comment * comment * update to chainlink-common master * typo
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in the same vein of work as smartcontractkit/chainlink-common#509.
Introducing a new gas price data source.
Merge Order