Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unimplemented ChainReader() method to MedianProvider #552

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Add unimplemented ChainReader() method to MedianProvider #552

merged 1 commit into from
Dec 6, 2023

Conversation

reductionista
Copy link
Contributor

@reductionista reductionista commented Oct 18, 2023 •
edited by ilija42
Loading

Just adds ChainReader() method to medianProvider to satisfy the updated PluginProvider interface which we plan to commit soon to chainlink-relay:

smartcontractkit/chainlink-common#196

core ref: BCF-2612-ChainReader-EVM-POC

@reductionista reductionista temporarily deployed to integration October 18, 2023 16:53 — with GitHub Actions Inactive
@reductionista reductionista temporarily deployed to integration October 18, 2023 16:53 — with GitHub Actions Inactive
@reductionista reductionista mentioned this pull request Oct 18, 2023
Merged
@reductionista reductionista temporarily deployed to integration October 24, 2023 21:38 — with GitHub Actions Inactive
@reductionista reductionista temporarily deployed to integration October 24, 2023 21:38 — with GitHub Actions Inactive
@reductionista reductionista temporarily deployed to integration October 25, 2023 02:45 — with GitHub Actions Inactive
@reductionista reductionista temporarily deployed to integration October 25, 2023 02:45 — with GitHub Actions Inactive
@reductionista reductionista temporarily deployed to integration October 27, 2023 00:21 — with GitHub Actions Inactive
@reductionista reductionista temporarily deployed to integration October 27, 2023 00:21 — with GitHub Actions Inactive
@reductionista reductionista temporarily deployed to integration November 1, 2023 17:35 — with GitHub Actions Inactive
@reductionista reductionista temporarily deployed to integration November 1, 2023 17:36 — with GitHub Actions Inactive
jmank88
jmank88 reviewed Nov 8, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@reductionista reductionista mentioned this pull request Nov 8, 2023
Merged
jmank88
jmank88 previously approved these changes Dec 5, 2023
View reviewed changes
@ilija42 ilija42 force-pushed the BCF-2612-ChainReader branch 3 times, most recently from dc21c14 to a517952 Compare December 6, 2023 14:26
@ilija42 ilija42 force-pushed the BCF-2612-ChainReader branch from a517952 to 212e082 Compare December 6, 2023 14:31
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@aalu1418
Copy link
Collaborator

aalu1418 commented Dec 6, 2023

overriding CI to merge - requires breaking core changes: smartcontractkit/chainlink#10990

@aalu1418 aalu1418 merged commit ec1718b into develop Dec 6, 2023
42 of 45 checks passed
@aalu1418 aalu1418 deleted the BCF-2612-ChainReader branch December 6, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 left review comments

@aalu1418 aalu1418 aalu1418 approved these changes

@nolag nolag nolag left review comments

@jmank88 jmank88 jmank88 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reductionista @aalu1418 @jmank88 @nolag @ilija42